mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-25 21:54:10 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Ensure workers terminated fully before reading unknownRefs

Browse source
This commit is contained in:
Fabian Reinartz 2017-10-11 10:12:29 +02:00
parent 6e94145515
commit 106eaf39d1
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
head.go
View file

@ -233,16 +233,20 @@ func (h *Head) ReadWAL() error {
// They are connected through a ring of channels which ensures that all sample batches // They are connected through a ring of channels which ensures that all sample batches
// read from the WAL are processed in order. // read from the WAL are processed in order.
var ( var (
wg sync.WaitGroup
n = runtime.GOMAXPROCS(0) n = runtime.GOMAXPROCS(0)
firstInput = make(chan []RefSample, 300) firstInput = make(chan []RefSample, 300)
input = firstInput input = firstInput
) )
wg.Add(n)
for i := 0; i < n; i++ { for i := 0; i < n; i++ {
output := make(chan []RefSample, 300) output := make(chan []RefSample, 300)
go func(i int, input <-chan []RefSample, output chan<- []RefSample) { go func(i int, input <-chan []RefSample, output chan<- []RefSample) {
unknown := h.processWALSamples(mint, uint64(i), uint64(n), input, output) unknown := h.processWALSamples(mint, uint64(i), uint64(n), input, output)
atomic.AddUint64(&unknownRefs, unknown) atomic.AddUint64(&unknownRefs, unknown)
wg.Done()
}(i, input, output) }(i, input, output)
// The output feeds the next worker goroutine. For the last worker, // The output feeds the next worker goroutine. For the last worker,
@ -288,6 +292,8 @@ func (h *Head) ReadWAL() error {
close(firstInput) close(firstInput)
for range input { for range input {
} }
wg.Wait()
if err != nil { if err != nil {
return errors.Wrap(err, "consume WAL") return errors.Wrap(err, "consume WAL")
} }