mirror of
https://github.com/prometheus/prometheus.git
synced 2024-12-26 06:04:05 -08:00
discovery: Improve Azure test coverage to 50% (#14586)
Some checks are pending
buf.build / lint and publish (push) Waiting to run
CI / Go tests (push) Waiting to run
CI / More Go tests (push) Waiting to run
CI / Go tests with previous Go version (push) Waiting to run
CI / UI tests (push) Waiting to run
CI / Go tests on Windows (push) Waiting to run
CI / Mixins tests (push) Waiting to run
CI / Build Prometheus for common architectures (0) (push) Waiting to run
CI / Build Prometheus for common architectures (1) (push) Waiting to run
CI / Build Prometheus for common architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (0) (push) Waiting to run
CI / Build Prometheus for all architectures (1) (push) Waiting to run
CI / Build Prometheus for all architectures (10) (push) Waiting to run
CI / Build Prometheus for all architectures (11) (push) Waiting to run
CI / Build Prometheus for all architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (3) (push) Waiting to run
CI / Build Prometheus for all architectures (4) (push) Waiting to run
CI / Build Prometheus for all architectures (5) (push) Waiting to run
CI / Build Prometheus for all architectures (6) (push) Waiting to run
CI / Build Prometheus for all architectures (7) (push) Waiting to run
CI / Build Prometheus for all architectures (8) (push) Waiting to run
CI / Build Prometheus for all architectures (9) (push) Waiting to run
CI / Report status of build Prometheus for all architectures (push) Blocked by required conditions
CI / Check generated parser (push) Waiting to run
CI / golangci-lint (push) Waiting to run
CI / fuzzing (push) Waiting to run
CI / codeql (push) Waiting to run
CI / Publish main branch artifacts (push) Blocked by required conditions
CI / Publish release artefacts (push) Blocked by required conditions
CI / Publish UI on npm Registry (push) Blocked by required conditions
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
Some checks are pending
buf.build / lint and publish (push) Waiting to run
CI / Go tests (push) Waiting to run
CI / More Go tests (push) Waiting to run
CI / Go tests with previous Go version (push) Waiting to run
CI / UI tests (push) Waiting to run
CI / Go tests on Windows (push) Waiting to run
CI / Mixins tests (push) Waiting to run
CI / Build Prometheus for common architectures (0) (push) Waiting to run
CI / Build Prometheus for common architectures (1) (push) Waiting to run
CI / Build Prometheus for common architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (0) (push) Waiting to run
CI / Build Prometheus for all architectures (1) (push) Waiting to run
CI / Build Prometheus for all architectures (10) (push) Waiting to run
CI / Build Prometheus for all architectures (11) (push) Waiting to run
CI / Build Prometheus for all architectures (2) (push) Waiting to run
CI / Build Prometheus for all architectures (3) (push) Waiting to run
CI / Build Prometheus for all architectures (4) (push) Waiting to run
CI / Build Prometheus for all architectures (5) (push) Waiting to run
CI / Build Prometheus for all architectures (6) (push) Waiting to run
CI / Build Prometheus for all architectures (7) (push) Waiting to run
CI / Build Prometheus for all architectures (8) (push) Waiting to run
CI / Build Prometheus for all architectures (9) (push) Waiting to run
CI / Report status of build Prometheus for all architectures (push) Blocked by required conditions
CI / Check generated parser (push) Waiting to run
CI / golangci-lint (push) Waiting to run
CI / fuzzing (push) Waiting to run
CI / codeql (push) Waiting to run
CI / Publish main branch artifacts (push) Blocked by required conditions
CI / Publish release artefacts (push) Blocked by required conditions
CI / Publish UI on npm Registry (push) Blocked by required conditions
Scorecards supply-chain security / Scorecards analysis (push) Waiting to run
* azure sd: separate refresh and refreshAzure * azure sd: create a client with mocked servers for tests * add test for refresh function --------- Signed-off-by: mviswanathsai <mviswanath.sai.met21@itbhu.ac.in>
This commit is contained in:
parent
7ce9cfa6e4
commit
16bba78f15
|
@ -233,21 +233,21 @@ type azureClient struct {
|
||||||
|
|
||||||
var _ client = &azureClient{}
|
var _ client = &azureClient{}
|
||||||
|
|
||||||
// createAzureClient is a helper function for creating an Azure compute client to ARM.
|
// createAzureClient is a helper method for creating an Azure compute client to ARM.
|
||||||
func createAzureClient(cfg SDConfig, logger *slog.Logger) (client, error) {
|
func (d *Discovery) createAzureClient() (client, error) {
|
||||||
cloudConfiguration, err := CloudConfigurationFromName(cfg.Environment)
|
cloudConfiguration, err := CloudConfigurationFromName(d.cfg.Environment)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return &azureClient{}, err
|
return &azureClient{}, err
|
||||||
}
|
}
|
||||||
|
|
||||||
var c azureClient
|
var c azureClient
|
||||||
c.logger = logger
|
c.logger = d.logger
|
||||||
|
|
||||||
telemetry := policy.TelemetryOptions{
|
telemetry := policy.TelemetryOptions{
|
||||||
ApplicationID: userAgent,
|
ApplicationID: userAgent,
|
||||||
}
|
}
|
||||||
|
|
||||||
credential, err := newCredential(cfg, policy.ClientOptions{
|
credential, err := newCredential(*d.cfg, policy.ClientOptions{
|
||||||
Cloud: cloudConfiguration,
|
Cloud: cloudConfiguration,
|
||||||
Telemetry: telemetry,
|
Telemetry: telemetry,
|
||||||
})
|
})
|
||||||
|
@ -255,7 +255,7 @@ func createAzureClient(cfg SDConfig, logger *slog.Logger) (client, error) {
|
||||||
return &azureClient{}, err
|
return &azureClient{}, err
|
||||||
}
|
}
|
||||||
|
|
||||||
client, err := config_util.NewClientFromConfig(cfg.HTTPClientConfig, "azure_sd")
|
client, err := config_util.NewClientFromConfig(d.cfg.HTTPClientConfig, "azure_sd")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return &azureClient{}, err
|
return &azureClient{}, err
|
||||||
}
|
}
|
||||||
|
@ -267,22 +267,22 @@ func createAzureClient(cfg SDConfig, logger *slog.Logger) (client, error) {
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
c.vm, err = armcompute.NewVirtualMachinesClient(cfg.SubscriptionID, credential, options)
|
c.vm, err = armcompute.NewVirtualMachinesClient(d.cfg.SubscriptionID, credential, options)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return &azureClient{}, err
|
return &azureClient{}, err
|
||||||
}
|
}
|
||||||
|
|
||||||
c.nic, err = armnetwork.NewInterfacesClient(cfg.SubscriptionID, credential, options)
|
c.nic, err = armnetwork.NewInterfacesClient(d.cfg.SubscriptionID, credential, options)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return &azureClient{}, err
|
return &azureClient{}, err
|
||||||
}
|
}
|
||||||
|
|
||||||
c.vmss, err = armcompute.NewVirtualMachineScaleSetsClient(cfg.SubscriptionID, credential, options)
|
c.vmss, err = armcompute.NewVirtualMachineScaleSetsClient(d.cfg.SubscriptionID, credential, options)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return &azureClient{}, err
|
return &azureClient{}, err
|
||||||
}
|
}
|
||||||
|
|
||||||
c.vmssvm, err = armcompute.NewVirtualMachineScaleSetVMsClient(cfg.SubscriptionID, credential, options)
|
c.vmssvm, err = armcompute.NewVirtualMachineScaleSetVMsClient(d.cfg.SubscriptionID, credential, options)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return &azureClient{}, err
|
return &azureClient{}, err
|
||||||
}
|
}
|
||||||
|
@ -350,15 +350,7 @@ func newAzureResourceFromID(id string, logger *slog.Logger) (*arm.ResourceID, er
|
||||||
return resourceID, nil
|
return resourceID, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (d *Discovery) refresh(ctx context.Context) ([]*targetgroup.Group, error) {
|
func (d *Discovery) refreshAzureClient(ctx context.Context, client client) ([]*targetgroup.Group, error) {
|
||||||
defer d.logger.Debug("Azure discovery completed")
|
|
||||||
|
|
||||||
client, err := createAzureClient(*d.cfg, d.logger)
|
|
||||||
if err != nil {
|
|
||||||
d.metrics.failuresCount.Inc()
|
|
||||||
return nil, fmt.Errorf("could not create Azure client: %w", err)
|
|
||||||
}
|
|
||||||
|
|
||||||
machines, err := client.getVMs(ctx, d.cfg.ResourceGroup)
|
machines, err := client.getVMs(ctx, d.cfg.ResourceGroup)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
d.metrics.failuresCount.Inc()
|
d.metrics.failuresCount.Inc()
|
||||||
|
@ -418,6 +410,18 @@ func (d *Discovery) refresh(ctx context.Context) ([]*targetgroup.Group, error) {
|
||||||
return []*targetgroup.Group{&tg}, nil
|
return []*targetgroup.Group{&tg}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (d *Discovery) refresh(ctx context.Context) ([]*targetgroup.Group, error) {
|
||||||
|
defer d.logger.Debug("Azure discovery completed")
|
||||||
|
|
||||||
|
client, err := d.createAzureClient()
|
||||||
|
if err != nil {
|
||||||
|
d.metrics.failuresCount.Inc()
|
||||||
|
return nil, fmt.Errorf("could not create Azure client: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
return d.refreshAzureClient(ctx, client)
|
||||||
|
}
|
||||||
|
|
||||||
func (d *Discovery) vmToLabelSet(ctx context.Context, client client, vm virtualMachine) (model.LabelSet, error) {
|
func (d *Discovery) vmToLabelSet(ctx context.Context, client client, vm virtualMachine) (model.LabelSet, error) {
|
||||||
r, err := newAzureResourceFromID(vm.ID, d.logger)
|
r, err := newAzureResourceFromID(vm.ID, d.logger)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
|
|
@ -15,19 +15,34 @@ package azure
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"fmt"
|
"log/slog"
|
||||||
|
"net/http"
|
||||||
|
"slices"
|
||||||
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
|
"github.com/Azure/azure-sdk-for-go/sdk/azcore"
|
||||||
"github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"
|
"github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"
|
||||||
|
azfake "github.com/Azure/azure-sdk-for-go/sdk/azcore/fake"
|
||||||
|
"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
|
||||||
"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5"
|
"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5"
|
||||||
|
fake "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5/fake"
|
||||||
"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4"
|
"github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4"
|
||||||
|
fakenetwork "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/v4/fake"
|
||||||
cache "github.com/Code-Hex/go-generics-cache"
|
cache "github.com/Code-Hex/go-generics-cache"
|
||||||
"github.com/Code-Hex/go-generics-cache/policy/lru"
|
"github.com/Code-Hex/go-generics-cache/policy/lru"
|
||||||
|
"github.com/prometheus/client_golang/prometheus"
|
||||||
|
"github.com/prometheus/common/model"
|
||||||
"github.com/prometheus/common/promslog"
|
"github.com/prometheus/common/promslog"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/stretchr/testify/require"
|
||||||
"go.uber.org/goleak"
|
"go.uber.org/goleak"
|
||||||
|
|
||||||
|
"github.com/prometheus/prometheus/discovery"
|
||||||
|
"github.com/prometheus/prometheus/discovery/targetgroup"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
const defaultMockNetworkID string = "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkInterfaces/{networkInterfaceName}"
|
||||||
|
|
||||||
func TestMain(m *testing.M) {
|
func TestMain(m *testing.M) {
|
||||||
goleak.VerifyTestMain(m,
|
goleak.VerifyTestMain(m,
|
||||||
goleak.IgnoreTopFunction("github.com/Code-Hex/go-generics-cache.(*janitor).run.func1"),
|
goleak.IgnoreTopFunction("github.com/Code-Hex/go-generics-cache.(*janitor).run.func1"),
|
||||||
|
@ -96,13 +111,12 @@ func TestVMToLabelSet(t *testing.T) {
|
||||||
vmType := "type"
|
vmType := "type"
|
||||||
location := "westeurope"
|
location := "westeurope"
|
||||||
computerName := "computer_name"
|
computerName := "computer_name"
|
||||||
networkID := "/subscriptions/00000000-0000-0000-0000-000000000000/network1"
|
|
||||||
ipAddress := "10.20.30.40"
|
ipAddress := "10.20.30.40"
|
||||||
primary := true
|
primary := true
|
||||||
networkProfile := armcompute.NetworkProfile{
|
networkProfile := armcompute.NetworkProfile{
|
||||||
NetworkInterfaces: []*armcompute.NetworkInterfaceReference{
|
NetworkInterfaces: []*armcompute.NetworkInterfaceReference{
|
||||||
{
|
{
|
||||||
ID: &networkID,
|
ID: to.Ptr(defaultMockNetworkID),
|
||||||
Properties: &armcompute.NetworkInterfaceReferenceProperties{Primary: &primary},
|
Properties: &armcompute.NetworkInterfaceReferenceProperties{Primary: &primary},
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
@ -139,7 +153,7 @@ func TestVMToLabelSet(t *testing.T) {
|
||||||
Location: location,
|
Location: location,
|
||||||
OsType: "Linux",
|
OsType: "Linux",
|
||||||
Tags: map[string]*string{},
|
Tags: map[string]*string{},
|
||||||
NetworkInterfaces: []string{networkID},
|
NetworkInterfaces: []string{defaultMockNetworkID},
|
||||||
Size: size,
|
Size: size,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -154,7 +168,8 @@ func TestVMToLabelSet(t *testing.T) {
|
||||||
cache: cache.New(cache.AsLRU[string, *armnetwork.Interface](lru.WithCapacity(5))),
|
cache: cache.New(cache.AsLRU[string, *armnetwork.Interface](lru.WithCapacity(5))),
|
||||||
}
|
}
|
||||||
network := armnetwork.Interface{
|
network := armnetwork.Interface{
|
||||||
Name: &networkID,
|
Name: to.Ptr(defaultMockNetworkID),
|
||||||
|
ID: to.Ptr(defaultMockNetworkID),
|
||||||
Properties: &armnetwork.InterfacePropertiesFormat{
|
Properties: &armnetwork.InterfacePropertiesFormat{
|
||||||
Primary: &primary,
|
Primary: &primary,
|
||||||
IPConfigurations: []*armnetwork.InterfaceIPConfiguration{
|
IPConfigurations: []*armnetwork.InterfaceIPConfiguration{
|
||||||
|
@ -164,9 +179,9 @@ func TestVMToLabelSet(t *testing.T) {
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
client := &mockAzureClient{
|
|
||||||
networkInterface: &network,
|
client := createMockAzureClient(t, nil, nil, nil, network, nil)
|
||||||
}
|
|
||||||
labelSet, err := d.vmToLabelSet(context.Background(), client, actualVM)
|
labelSet, err := d.vmToLabelSet(context.Background(), client, actualVM)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
require.Len(t, labelSet, 11)
|
require.Len(t, labelSet, 11)
|
||||||
|
@ -475,34 +490,372 @@ func TestNewAzureResourceFromID(t *testing.T) {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestAzureRefresh(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
scenario string
|
||||||
|
vmResp []armcompute.VirtualMachinesClientListAllResponse
|
||||||
|
vmssResp []armcompute.VirtualMachineScaleSetsClientListAllResponse
|
||||||
|
vmssvmResp []armcompute.VirtualMachineScaleSetVMsClientListResponse
|
||||||
|
interfacesResp armnetwork.Interface
|
||||||
|
expectedTG []*targetgroup.Group
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
scenario: "VMs, VMSS and VMSSVMs in Multiple Responses",
|
||||||
|
vmResp: []armcompute.VirtualMachinesClientListAllResponse{
|
||||||
|
{
|
||||||
|
VirtualMachineListResult: armcompute.VirtualMachineListResult{
|
||||||
|
Value: []*armcompute.VirtualMachine{
|
||||||
|
defaultVMWithIDAndName(to.Ptr("/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/vm1"), to.Ptr("vm1")),
|
||||||
|
defaultVMWithIDAndName(to.Ptr("/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/vm2"), to.Ptr("vm2")),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
VirtualMachineListResult: armcompute.VirtualMachineListResult{
|
||||||
|
Value: []*armcompute.VirtualMachine{
|
||||||
|
defaultVMWithIDAndName(to.Ptr("/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/vm3"), to.Ptr("vm3")),
|
||||||
|
defaultVMWithIDAndName(to.Ptr("/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/vm4"), to.Ptr("vm4")),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
vmssResp: []armcompute.VirtualMachineScaleSetsClientListAllResponse{
|
||||||
|
{
|
||||||
|
VirtualMachineScaleSetListWithLinkResult: armcompute.VirtualMachineScaleSetListWithLinkResult{
|
||||||
|
Value: []*armcompute.VirtualMachineScaleSet{
|
||||||
|
{
|
||||||
|
ID: to.Ptr("/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachineScaleSets/vmScaleSet1"),
|
||||||
|
Name: to.Ptr("vmScaleSet1"),
|
||||||
|
Location: to.Ptr("australiaeast"),
|
||||||
|
Type: to.Ptr("Microsoft.Compute/virtualMachineScaleSets"),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
vmssvmResp: []armcompute.VirtualMachineScaleSetVMsClientListResponse{
|
||||||
|
{
|
||||||
|
VirtualMachineScaleSetVMListResult: armcompute.VirtualMachineScaleSetVMListResult{
|
||||||
|
Value: []*armcompute.VirtualMachineScaleSetVM{
|
||||||
|
defaultVMSSVMWithIDAndName(to.Ptr("/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachineScaleSets/vmScaleSet1/virtualMachines/vmScaleSet1_vm1"), to.Ptr("vmScaleSet1_vm1")),
|
||||||
|
defaultVMSSVMWithIDAndName(to.Ptr("/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachineScaleSets/vmScaleSet1/virtualMachines/vmScaleSet1_vm2"), to.Ptr("vmScaleSet1_vm2")),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
interfacesResp: armnetwork.Interface{
|
||||||
|
ID: to.Ptr(defaultMockNetworkID),
|
||||||
|
Properties: &armnetwork.InterfacePropertiesFormat{
|
||||||
|
Primary: to.Ptr(true),
|
||||||
|
IPConfigurations: []*armnetwork.InterfaceIPConfiguration{
|
||||||
|
{Properties: &armnetwork.InterfaceIPConfigurationPropertiesFormat{
|
||||||
|
PrivateIPAddress: to.Ptr("10.0.0.1"),
|
||||||
|
}},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
expectedTG: []*targetgroup.Group{
|
||||||
|
{
|
||||||
|
Targets: []model.LabelSet{
|
||||||
|
{
|
||||||
|
"__address__": "10.0.0.1:80",
|
||||||
|
"__meta_azure_machine_computer_name": "computer_name",
|
||||||
|
"__meta_azure_machine_id": "/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/vm1",
|
||||||
|
"__meta_azure_machine_location": "australiaeast",
|
||||||
|
"__meta_azure_machine_name": "vm1",
|
||||||
|
"__meta_azure_machine_os_type": "Linux",
|
||||||
|
"__meta_azure_machine_private_ip": "10.0.0.1",
|
||||||
|
"__meta_azure_machine_resource_group": "{resourceGroup}",
|
||||||
|
"__meta_azure_machine_size": "size",
|
||||||
|
"__meta_azure_machine_tag_prometheus": "",
|
||||||
|
"__meta_azure_subscription_id": "",
|
||||||
|
"__meta_azure_tenant_id": "",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"__address__": "10.0.0.1:80",
|
||||||
|
"__meta_azure_machine_computer_name": "computer_name",
|
||||||
|
"__meta_azure_machine_id": "/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/vm2",
|
||||||
|
"__meta_azure_machine_location": "australiaeast",
|
||||||
|
"__meta_azure_machine_name": "vm2",
|
||||||
|
"__meta_azure_machine_os_type": "Linux",
|
||||||
|
"__meta_azure_machine_private_ip": "10.0.0.1",
|
||||||
|
"__meta_azure_machine_resource_group": "{resourceGroup}",
|
||||||
|
"__meta_azure_machine_size": "size",
|
||||||
|
"__meta_azure_machine_tag_prometheus": "",
|
||||||
|
"__meta_azure_subscription_id": "",
|
||||||
|
"__meta_azure_tenant_id": "",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"__address__": "10.0.0.1:80",
|
||||||
|
"__meta_azure_machine_computer_name": "computer_name",
|
||||||
|
"__meta_azure_machine_id": "/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/vm3",
|
||||||
|
"__meta_azure_machine_location": "australiaeast",
|
||||||
|
"__meta_azure_machine_name": "vm3",
|
||||||
|
"__meta_azure_machine_os_type": "Linux",
|
||||||
|
"__meta_azure_machine_private_ip": "10.0.0.1",
|
||||||
|
"__meta_azure_machine_resource_group": "{resourceGroup}",
|
||||||
|
"__meta_azure_machine_size": "size",
|
||||||
|
"__meta_azure_machine_tag_prometheus": "",
|
||||||
|
"__meta_azure_subscription_id": "",
|
||||||
|
"__meta_azure_tenant_id": "",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"__address__": "10.0.0.1:80",
|
||||||
|
"__meta_azure_machine_computer_name": "computer_name",
|
||||||
|
"__meta_azure_machine_id": "/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/vm4",
|
||||||
|
"__meta_azure_machine_location": "australiaeast",
|
||||||
|
"__meta_azure_machine_name": "vm4",
|
||||||
|
"__meta_azure_machine_os_type": "Linux",
|
||||||
|
"__meta_azure_machine_private_ip": "10.0.0.1",
|
||||||
|
"__meta_azure_machine_resource_group": "{resourceGroup}",
|
||||||
|
"__meta_azure_machine_size": "size",
|
||||||
|
"__meta_azure_machine_tag_prometheus": "",
|
||||||
|
"__meta_azure_subscription_id": "",
|
||||||
|
"__meta_azure_tenant_id": "",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"__address__": "10.0.0.1:80",
|
||||||
|
"__meta_azure_machine_computer_name": "computer_name",
|
||||||
|
"__meta_azure_machine_id": "/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachineScaleSets/vmScaleSet1/virtualMachines/vmScaleSet1_vm1",
|
||||||
|
"__meta_azure_machine_location": "australiaeast",
|
||||||
|
"__meta_azure_machine_name": "vmScaleSet1_vm1",
|
||||||
|
"__meta_azure_machine_os_type": "Linux",
|
||||||
|
"__meta_azure_machine_private_ip": "10.0.0.1",
|
||||||
|
"__meta_azure_machine_resource_group": "{resourceGroup}",
|
||||||
|
"__meta_azure_machine_scale_set": "vmScaleSet1",
|
||||||
|
"__meta_azure_machine_size": "size",
|
||||||
|
"__meta_azure_machine_tag_prometheus": "",
|
||||||
|
"__meta_azure_subscription_id": "",
|
||||||
|
"__meta_azure_tenant_id": "",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"__address__": "10.0.0.1:80",
|
||||||
|
"__meta_azure_machine_computer_name": "computer_name",
|
||||||
|
"__meta_azure_machine_id": "/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachineScaleSets/vmScaleSet1/virtualMachines/vmScaleSet1_vm2",
|
||||||
|
"__meta_azure_machine_location": "australiaeast",
|
||||||
|
"__meta_azure_machine_name": "vmScaleSet1_vm2",
|
||||||
|
"__meta_azure_machine_os_type": "Linux",
|
||||||
|
"__meta_azure_machine_private_ip": "10.0.0.1",
|
||||||
|
"__meta_azure_machine_resource_group": "{resourceGroup}",
|
||||||
|
"__meta_azure_machine_scale_set": "vmScaleSet1",
|
||||||
|
"__meta_azure_machine_size": "size",
|
||||||
|
"__meta_azure_machine_tag_prometheus": "",
|
||||||
|
"__meta_azure_subscription_id": "",
|
||||||
|
"__meta_azure_tenant_id": "",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
for _, tc := range tests {
|
||||||
|
t.Run(tc.scenario, func(t *testing.T) {
|
||||||
|
t.Parallel()
|
||||||
|
azureSDConfig := &DefaultSDConfig
|
||||||
|
|
||||||
|
azureClient := createMockAzureClient(t, tc.vmResp, tc.vmssResp, tc.vmssvmResp, tc.interfacesResp, nil)
|
||||||
|
|
||||||
|
reg := prometheus.NewRegistry()
|
||||||
|
refreshMetrics := discovery.NewRefreshMetrics(reg)
|
||||||
|
metrics := azureSDConfig.NewDiscovererMetrics(reg, refreshMetrics)
|
||||||
|
|
||||||
|
sd, err := NewDiscovery(azureSDConfig, nil, metrics)
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
tg, err := sd.refreshAzureClient(context.Background(), azureClient)
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
sortTargetsByID(tg[0].Targets)
|
||||||
|
require.Equal(t, tc.expectedTG, tg)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
type mockAzureClient struct {
|
type mockAzureClient struct {
|
||||||
networkInterface *armnetwork.Interface
|
azureClient
|
||||||
}
|
}
|
||||||
|
|
||||||
var _ client = &mockAzureClient{}
|
func createMockAzureClient(t *testing.T, vmResp []armcompute.VirtualMachinesClientListAllResponse, vmssResp []armcompute.VirtualMachineScaleSetsClientListAllResponse, vmssvmResp []armcompute.VirtualMachineScaleSetVMsClientListResponse, interfaceResp armnetwork.Interface, logger *slog.Logger) client {
|
||||||
|
t.Helper()
|
||||||
|
mockVMServer := defaultMockVMServer(vmResp)
|
||||||
|
mockVMSSServer := defaultMockVMSSServer(vmssResp)
|
||||||
|
mockVMScaleSetVMServer := defaultMockVMSSVMServer(vmssvmResp)
|
||||||
|
mockInterfaceServer := defaultMockInterfaceServer(interfaceResp)
|
||||||
|
|
||||||
func (*mockAzureClient) getVMs(ctx context.Context, resourceGroup string) ([]virtualMachine, error) {
|
vmClient, err := armcompute.NewVirtualMachinesClient("fake-subscription-id", &azfake.TokenCredential{}, &arm.ClientOptions{
|
||||||
return nil, nil
|
ClientOptions: azcore.ClientOptions{
|
||||||
}
|
Transport: fake.NewVirtualMachinesServerTransport(&mockVMServer),
|
||||||
|
},
|
||||||
|
})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
func (*mockAzureClient) getScaleSets(ctx context.Context, resourceGroup string) ([]armcompute.VirtualMachineScaleSet, error) {
|
vmssClient, err := armcompute.NewVirtualMachineScaleSetsClient("fake-subscription-id", &azfake.TokenCredential{}, &arm.ClientOptions{
|
||||||
return nil, nil
|
ClientOptions: azcore.ClientOptions{
|
||||||
}
|
Transport: fake.NewVirtualMachineScaleSetsServerTransport(&mockVMSSServer),
|
||||||
|
},
|
||||||
|
})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
func (*mockAzureClient) getScaleSetVMs(ctx context.Context, scaleSet armcompute.VirtualMachineScaleSet) ([]virtualMachine, error) {
|
vmssvmClient, err := armcompute.NewVirtualMachineScaleSetVMsClient("fake-subscription-id", &azfake.TokenCredential{}, &arm.ClientOptions{
|
||||||
return nil, nil
|
ClientOptions: azcore.ClientOptions{
|
||||||
}
|
Transport: fake.NewVirtualMachineScaleSetVMsServerTransport(&mockVMScaleSetVMServer),
|
||||||
|
},
|
||||||
|
})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
func (m *mockAzureClient) getVMNetworkInterfaceByID(ctx context.Context, networkInterfaceID string) (*armnetwork.Interface, error) {
|
interfacesClient, err := armnetwork.NewInterfacesClient("fake-subscription-id", &azfake.TokenCredential{}, &arm.ClientOptions{
|
||||||
if networkInterfaceID == "" {
|
ClientOptions: azcore.ClientOptions{
|
||||||
return nil, fmt.Errorf("parameter networkInterfaceID cannot be empty")
|
Transport: fakenetwork.NewInterfacesServerTransport(&mockInterfaceServer),
|
||||||
|
},
|
||||||
|
})
|
||||||
|
require.NoError(t, err)
|
||||||
|
|
||||||
|
return &mockAzureClient{
|
||||||
|
azureClient: azureClient{
|
||||||
|
vm: vmClient,
|
||||||
|
vmss: vmssClient,
|
||||||
|
vmssvm: vmssvmClient,
|
||||||
|
nic: interfacesClient,
|
||||||
|
logger: logger,
|
||||||
|
},
|
||||||
}
|
}
|
||||||
return m.networkInterface, nil
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func (m *mockAzureClient) getVMScaleSetVMNetworkInterfaceByID(ctx context.Context, networkInterfaceID, scaleSetName, instanceID string) (*armnetwork.Interface, error) {
|
func defaultMockInterfaceServer(interfaceResp armnetwork.Interface) fakenetwork.InterfacesServer {
|
||||||
if scaleSetName == "" {
|
return fakenetwork.InterfacesServer{
|
||||||
return nil, fmt.Errorf("parameter virtualMachineScaleSetName cannot be empty")
|
Get: func(ctx context.Context, resourceGroupName, networkInterfaceName string, options *armnetwork.InterfacesClientGetOptions) (resp azfake.Responder[armnetwork.InterfacesClientGetResponse], errResp azfake.ErrorResponder) {
|
||||||
|
resp.SetResponse(http.StatusOK, armnetwork.InterfacesClientGetResponse{Interface: interfaceResp}, nil)
|
||||||
|
return
|
||||||
|
},
|
||||||
|
GetVirtualMachineScaleSetNetworkInterface: func(ctx context.Context, resourceGroupName, virtualMachineScaleSetName, virtualmachineIndex, networkInterfaceName string, options *armnetwork.InterfacesClientGetVirtualMachineScaleSetNetworkInterfaceOptions) (resp azfake.Responder[armnetwork.InterfacesClientGetVirtualMachineScaleSetNetworkInterfaceResponse], errResp azfake.ErrorResponder) {
|
||||||
|
resp.SetResponse(http.StatusOK, armnetwork.InterfacesClientGetVirtualMachineScaleSetNetworkInterfaceResponse{Interface: interfaceResp}, nil)
|
||||||
|
return
|
||||||
|
},
|
||||||
}
|
}
|
||||||
return m.networkInterface, nil
|
}
|
||||||
|
|
||||||
|
func defaultMockVMServer(vmResp []armcompute.VirtualMachinesClientListAllResponse) fake.VirtualMachinesServer {
|
||||||
|
return fake.VirtualMachinesServer{
|
||||||
|
NewListAllPager: func(options *armcompute.VirtualMachinesClientListAllOptions) (resp azfake.PagerResponder[armcompute.VirtualMachinesClientListAllResponse]) {
|
||||||
|
for _, page := range vmResp {
|
||||||
|
resp.AddPage(http.StatusOK, page, nil)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func defaultMockVMSSServer(vmssResp []armcompute.VirtualMachineScaleSetsClientListAllResponse) fake.VirtualMachineScaleSetsServer {
|
||||||
|
return fake.VirtualMachineScaleSetsServer{
|
||||||
|
NewListAllPager: func(options *armcompute.VirtualMachineScaleSetsClientListAllOptions) (resp azfake.PagerResponder[armcompute.VirtualMachineScaleSetsClientListAllResponse]) {
|
||||||
|
for _, page := range vmssResp {
|
||||||
|
resp.AddPage(http.StatusOK, page, nil)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func defaultMockVMSSVMServer(vmssvmResp []armcompute.VirtualMachineScaleSetVMsClientListResponse) fake.VirtualMachineScaleSetVMsServer {
|
||||||
|
return fake.VirtualMachineScaleSetVMsServer{
|
||||||
|
NewListPager: func(resourceGroupName, virtualMachineScaleSetName string, options *armcompute.VirtualMachineScaleSetVMsClientListOptions) (resp azfake.PagerResponder[armcompute.VirtualMachineScaleSetVMsClientListResponse]) {
|
||||||
|
for _, page := range vmssvmResp {
|
||||||
|
resp.AddPage(http.StatusOK, page, nil)
|
||||||
|
}
|
||||||
|
return
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func defaultVMWithIDAndName(id, name *string) *armcompute.VirtualMachine {
|
||||||
|
vmSize := armcompute.VirtualMachineSizeTypes("size")
|
||||||
|
osType := armcompute.OperatingSystemTypesLinux
|
||||||
|
defaultID := "/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachine/testVM"
|
||||||
|
defaultName := "testVM"
|
||||||
|
|
||||||
|
if id == nil {
|
||||||
|
id = &defaultID
|
||||||
|
}
|
||||||
|
if name == nil {
|
||||||
|
name = &defaultName
|
||||||
|
}
|
||||||
|
|
||||||
|
return &armcompute.VirtualMachine{
|
||||||
|
ID: id,
|
||||||
|
Name: name,
|
||||||
|
Type: to.Ptr("Microsoft.Compute/virtualMachines"),
|
||||||
|
Location: to.Ptr("australiaeast"),
|
||||||
|
Properties: &armcompute.VirtualMachineProperties{
|
||||||
|
OSProfile: &armcompute.OSProfile{
|
||||||
|
ComputerName: to.Ptr("computer_name"),
|
||||||
|
},
|
||||||
|
StorageProfile: &armcompute.StorageProfile{
|
||||||
|
OSDisk: &armcompute.OSDisk{
|
||||||
|
OSType: &osType,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
NetworkProfile: &armcompute.NetworkProfile{
|
||||||
|
NetworkInterfaces: []*armcompute.NetworkInterfaceReference{
|
||||||
|
{
|
||||||
|
ID: to.Ptr(defaultMockNetworkID),
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
HardwareProfile: &armcompute.HardwareProfile{
|
||||||
|
VMSize: &vmSize,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Tags: map[string]*string{
|
||||||
|
"prometheus": new(string),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func defaultVMSSVMWithIDAndName(id, name *string) *armcompute.VirtualMachineScaleSetVM {
|
||||||
|
vmSize := armcompute.VirtualMachineSizeTypes("size")
|
||||||
|
osType := armcompute.OperatingSystemTypesLinux
|
||||||
|
defaultID := "/subscriptions/00000000-0000-0000-0000-00000000000/resourceGroups/{resourceGroup}/providers/Microsoft.Compute/virtualMachineScaleSets/testVMScaleSet/virtualMachines/testVM"
|
||||||
|
defaultName := "testVM"
|
||||||
|
|
||||||
|
if id == nil {
|
||||||
|
id = &defaultID
|
||||||
|
}
|
||||||
|
if name == nil {
|
||||||
|
name = &defaultName
|
||||||
|
}
|
||||||
|
|
||||||
|
return &armcompute.VirtualMachineScaleSetVM{
|
||||||
|
ID: id,
|
||||||
|
Name: name,
|
||||||
|
Type: to.Ptr("Microsoft.Compute/virtualMachines"),
|
||||||
|
InstanceID: to.Ptr("123"),
|
||||||
|
Location: to.Ptr("australiaeast"),
|
||||||
|
Properties: &armcompute.VirtualMachineScaleSetVMProperties{
|
||||||
|
OSProfile: &armcompute.OSProfile{
|
||||||
|
ComputerName: to.Ptr("computer_name"),
|
||||||
|
},
|
||||||
|
StorageProfile: &armcompute.StorageProfile{
|
||||||
|
OSDisk: &armcompute.OSDisk{
|
||||||
|
OSType: &osType,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
NetworkProfile: &armcompute.NetworkProfile{
|
||||||
|
NetworkInterfaces: []*armcompute.NetworkInterfaceReference{
|
||||||
|
{ID: to.Ptr(defaultMockNetworkID)},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
HardwareProfile: &armcompute.HardwareProfile{
|
||||||
|
VMSize: &vmSize,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
Tags: map[string]*string{
|
||||||
|
"prometheus": new(string),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func sortTargetsByID(targets []model.LabelSet) {
|
||||||
|
slices.SortFunc(targets, func(a, b model.LabelSet) int {
|
||||||
|
return strings.Compare(string(a["__meta_azure_machine_id"]), string(b["__meta_azure_machine_id"]))
|
||||||
|
})
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue