mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-15 01:54:06 -08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Account for repeating tenants when comparing rules

Browse source
This commit is contained in:
Dimitar Dimitrov 2022-01-21 14:21:50 +01:00
parent bc7a802871
commit 16faee8b78
No known key found for this signature in database
GPG key ID: 4541B04E6C90EBC3
1 changed files with 19 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
rules/manager.go
View file

@ -875,22 +875,27 @@ func (g *Group) Equals(ng *Group) bool {
return false return false
} }
} }
{
// compare source tenants ignoring their order // compare source tenants
if len(g.sourceTenants) != len(ng.sourceTenants) { if len(g.sourceTenants) != len(ng.sourceTenants) {
return false
}
thisSourceTenants := make(map[string]struct{}, len(g.sourceTenants))
for _, tenant := range g.sourceTenants {
thisSourceTenants[tenant] = struct{}{}
}
for _, tenant := range ng.sourceTenants {
if _, ok := thisSourceTenants[tenant]; !ok {
return false return false
} }
copyAndSort := func(x []string) []string {
copied := make([]string, len(x))
copy(copied, x)
sort.Strings(copied)
return copied
}
ngSourceTenantsCopy := copyAndSort(ng.sourceTenants)
gSourceTenantsCopy := copyAndSort(g.sourceTenants)
for i := range ngSourceTenantsCopy {
if gSourceTenantsCopy[i] != ngSourceTenantsCopy[i] {
return false
}
}
} }
return true return true