mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Refactor testutil/protobuf.go into scrape package

Browse source 
Renamed to clientprotobuf.go and added comments to indicate the
intended usage.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This commit is contained in:
György Krajcsovits 2023-05-04 08:36:44 +02:00
parent e9b2d87443
commit 19a4f314f5
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
util/testutil/protobuf.go → scrape/clientprotobuf.go
View file

@ -11,17 +11,19 @@
// See the License for the specific language governing permissions and // See the License for the specific language governing permissions and
// limitations under the License. // limitations under the License.
package testutil package scrape
import ( import (
"bytes" "bytes"
"encoding/binary" "encoding/binary"
"github.com/gogo/protobuf/proto" "github.com/gogo/protobuf/proto"
// Intentionally using client model to simulate client in tests.
dto "github.com/prometheus/client_model/go" dto "github.com/prometheus/client_model/go"
) )
// Write a MetricFamily into a protobuf // Write a MetricFamily into a protobuf.
// This function is intended for testing scraping by providing protobuf serialized input.
func MetricFamilyToProtobuf(metricFamily *dto.MetricFamily) ([]byte, error) { func MetricFamilyToProtobuf(metricFamily *dto.MetricFamily) ([]byte, error) {
buffer := &bytes.Buffer{} buffer := &bytes.Buffer{}
err := AddMetricFamilyToProtobuf(buffer, metricFamily) err := AddMetricFamilyToProtobuf(buffer, metricFamily)
@ -31,7 +33,8 @@ func MetricFamilyToProtobuf(metricFamily *dto.MetricFamily) ([]byte, error) {
return buffer.Bytes(), nil return buffer.Bytes(), nil
} }
// Append a MetricFamily protobuf representation to a buffer // Append a MetricFamily protobuf representation to a buffer.
// This function is intended for testing scraping by providing protobuf serialized input.
func AddMetricFamilyToProtobuf(buffer *bytes.Buffer, metricFamily *dto.MetricFamily) error { func AddMetricFamilyToProtobuf(buffer *bytes.Buffer, metricFamily *dto.MetricFamily) error {
protoBuf, err := proto.Marshal(metricFamily) protoBuf, err := proto.Marshal(metricFamily)
if err != nil { if err != nil {

4
scrape/scrape_test.go
View file

@ -1766,7 +1766,7 @@ func TestScrapeLoop_HistogramBucketLimit(t *testing.T) {
require.NotEmpty(t, gathered) require.NotEmpty(t, gathered)
histogramMetricFamily := gathered[0] histogramMetricFamily := gathered[0]
msg, err := testutil.MetricFamilyToProtobuf(histogramMetricFamily) msg, err := MetricFamilyToProtobuf(histogramMetricFamily)
require.NoError(t, err) require.NoError(t, err)
now := time.Now() now := time.Now()
@ -1789,7 +1789,7 @@ func TestScrapeLoop_HistogramBucketLimit(t *testing.T) {
require.NotEmpty(t, gathered) require.NotEmpty(t, gathered)
histogramMetricFamily = gathered[0] histogramMetricFamily = gathered[0]
msg, err = testutil.MetricFamilyToProtobuf(histogramMetricFamily) msg, err = MetricFamilyToProtobuf(histogramMetricFamily)
require.NoError(t, err) require.NoError(t, err)
now = time.Now() now = time.Now()