mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-12 22:37:27 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix rate() per-second adjustment.

Browse source 
This got broken during the depointerization of the Vector type.
This commit is contained in:
Julius Volz 2013-04-15 14:39:05 +02:00
parent 62f33f1fc2
commit 1cff4f3d91
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
rules/ast/functions.go
View file

@ -137,8 +137,8 @@ func rateImpl(timestamp time.Time, view *viewAdapter, args []Node) interface{} {
// MatrixLiteral exists). Find a better way of getting the duration of a // MatrixLiteral exists). Find a better way of getting the duration of a
// matrix, such as looking at the samples themselves. // matrix, such as looking at the samples themselves.
interval := args[0].(*MatrixLiteral).interval interval := args[0].(*MatrixLiteral).interval
for _, sample := range vector { for i, _ := range vector {
sample.Value /= model.SampleValue(interval / time.Second) vector[i].Value /= model.SampleValue(interval / time.Second)
} }
return vector return vector
} }

6
rules/rules_test.go
View file

@ -232,6 +232,12 @@ var expressionTests = []struct {
output: []string{"http_requests{group='canary',instance='1',job='app-server'} => 288 @[%v]"}, output: []string{"http_requests{group='canary',instance='1',job='app-server'} => 288 @[%v]"},
fullRanges: 1, fullRanges: 1,
intervalRanges: 0, intervalRanges: 0,
}, {
// Rates should transform per-interval deltas to per-second rates.
expr: "rate(http_requests{group='canary',instance='1',job='app-server'}[10m])",
output: []string{"http_requests{group='canary',instance='1',job='app-server'} => 0.26666668 @[%v]"},
fullRanges: 1,
intervalRanges: 0,
}, { }, {
// Empty expressions shouldn't parse. // Empty expressions shouldn't parse.
expr: "", expr: "",