mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Return empty string to signal non-caching

Browse source
This commit is contained in:
Fabian Reinartz 2017-06-26 14:58:00 +02:00
parent 3410559c1b
commit 1e74c155eb
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
db.go
View file

@ -80,6 +80,7 @@ type Appender interface {
// Returned reference numbers are ephemeral and may be rejected in calls // Returned reference numbers are ephemeral and may be rejected in calls
// to AddFast() at any point. Adding the sample via Add() returns a new // to AddFast() at any point. Adding the sample via Add() returns a new
// reference number. // reference number.
// If the reference is the empty string it must not be used for caching.
Add(l labels.Labels, t int64, v float64) (string, error) Add(l labels.Labels, t int64, v float64) (string, error)
// Add adds a sample pair for the referenced series. It is generally faster // Add adds a sample pair for the referenced series. It is generally faster
@ -616,6 +617,9 @@ func (a *dbAppender) Add(lset labels.Labels, t int64, v float64) (string, error)
} }
a.samples++ a.samples++
if ref == "" {
return "", nil
}
return string(append(h.meta.ULID[:], ref...)), nil return string(append(h.meta.ULID[:], ref...)), nil
} }

6
head.go
View file

@ -450,7 +450,7 @@ func (a *headAppender) Add(lset labels.Labels, t int64, v float64) (string, erro
// XXX(fabxc): there's no fast path for multiple samples for the same new series // XXX(fabxc): there's no fast path for multiple samples for the same new series
// in the same transaction. We always return the invalid empty ref. It's has not // in the same transaction. We always return the invalid empty ref. It's has not
// been a relevant use case so far and is not worth the trouble. // been a relevant use case so far and is not worth the trouble.
return nullRef, a.AddFast(string(refb), t, v) return "", a.AddFast(string(refb), t, v)
} }
// The series is completely new. // The series is completely new.
@ -471,11 +471,9 @@ func (a *headAppender) Add(lset labels.Labels, t int64, v float64) (string, erro
a.newHashes[hash] = ref a.newHashes[hash] = ref
binary.BigEndian.PutUint64(refb, ref) binary.BigEndian.PutUint64(refb, ref)
return nullRef, a.AddFast(string(refb), t, v) return "", a.AddFast(string(refb), t, v)
} }
var nullRef = string([]byte{0, 0, 0, 0, 0, 0, 0, 0})
func (a *headAppender) AddFast(ref string, t int64, v float64) error { func (a *headAppender) AddFast(ref string, t int64, v float64) error {
if len(ref) != 8 { if len(ref) != 8 {
return errors.Wrap(ErrNotFound, "invalid ref length") return errors.Wrap(ErrNotFound, "invalid ref length")