mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

return bool when truncated

Browse source 
Signed-off-by: Vandit Singh <vanditsinghkv@gmail.com>
This commit is contained in:
Vandit Singh 2024-12-18 23:46:11 +05:30
parent f736a6f7af
commit 21360653c6
1 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
web/api/v1/api.go
View file

@ -482,8 +482,12 @@ func (api *API) query(r *http.Request) (result apiFuncResult) {
warnings := res.Warnings warnings := res.Warnings
if limit > 0 { if limit > 0 {
res = truncateResults(res, limit) var isTruncated bool
warnings = warnings.Add(errors.New("results truncated due to limit"))
res, isTruncated = truncateResults(res, limit)
if isTruncated {
warnings = warnings.Add(errors.New("results truncated due to limit"))
}
} }
// Optional stats field in response if parameter "stats" is not empty. // Optional stats field in response if parameter "stats" is not empty.
sr := api.statsRenderer sr := api.statsRenderer
@ -600,10 +604,14 @@ func (api *API) queryRange(r *http.Request) (result apiFuncResult) {
return apiFuncResult{nil, returnAPIError(res.Err), res.Warnings, qry.Close} return apiFuncResult{nil, returnAPIError(res.Err), res.Warnings, qry.Close}
} }
var warnings annotations.Annotations warnings := res.Warnings
if limit > 0 { if limit > 0 {
res = truncateResults(res, limit) var isTruncated bool
warnings = warnings.Add(errors.New("results truncated due to limit"))
res, isTruncated = truncateResults(res, limit)
if isTruncated {
warnings = warnings.Add(errors.New("results truncated due to limit"))
}
} }
// Optional stats field in response if parameter "stats" is not empty. // Optional stats field in response if parameter "stats" is not empty.
@ -2121,17 +2129,22 @@ func toHintLimit(limit int) int {
// truncateResults truncates result for queryRange() and query(). // truncateResults truncates result for queryRange() and query().
// No truncation for other types(Scalars or Strings). // No truncation for other types(Scalars or Strings).
func truncateResults(result *promql.Result, limit int) *promql.Result { func truncateResults(result *promql.Result, limit int) (*promql.Result, bool) {
isTruncated := false
switch v := result.Value.(type) { switch v := result.Value.(type) {
case promql.Matrix: case promql.Matrix:
if len(v) > limit { if len(v) > limit {
result.Value = v[:limit] result.Value = v[:limit]
isTruncated = true
} }
case promql.Vector: case promql.Vector:
if len(v) > limit { if len(v) > limit {
result.Value = v[:limit] result.Value = v[:limit]
isTruncated = true
} }
} }
// Return the modified result. Unchanged for other types. // Return the modified result. Unchanged for other types.
return result return result, isTruncated
} }