From 22d3a4311ae081d3a05888410527d0f4da0b3705 Mon Sep 17 00:00:00 2001 From: beorn7 Date: Mon, 14 Sep 2015 21:09:46 +0200 Subject: [PATCH] Increase waiting time in TestEvictAndLoadChunkDescs The test had become flaky with Go1.5. Theory here is that with Go1.5.x, sleeping for 10ms might not be enough to wake up another goroutine, possibly because it is used for GC. 50ms should always be enough due to GC pause guarantees with the new GC. --- storage/local/storage_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage/local/storage_test.go b/storage/local/storage_test.go index a8ea0a7c39..30d1fb6558 100644 --- a/storage/local/storage_test.go +++ b/storage/local/storage_test.go @@ -1200,7 +1200,7 @@ func testEvictAndLoadChunkDescs(t *testing.T, encoding chunkEncoding) { // Maintain series without any dropped chunks. s.maintainMemorySeries(fp, 0) // Give the evict goroutine an opportunity to run. - time.Sleep(10 * time.Millisecond) + time.Sleep(50 * time.Millisecond) // Maintain series again to trigger chunkDesc eviction s.maintainMemorySeries(fp, 0)