mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Fix missing MinTime in histogram chunks

Browse source 
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
This commit is contained in:
Jeanette Tan 2023-11-01 19:53:41 +08:00
parent 2f7060bd5a
commit 27abf09e7f
1 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
tsdb/querier.go
View file

@ -855,13 +855,18 @@ func (p *populateWithDelChunkSeriesIterator) Next() bool {
if app, err = newChunk.Appender(); err != nil { if app, err = newChunk.Appender(); err != nil {
break break
} }
var h *histogram.Histogram
for vt := valueType; vt != chunkenc.ValNone; vt = p.currDelIter.Next() { t, h = p.currDelIter.AtHistogram()
p.curr.MinTime = t
_, _, app, err = app.AppendHistogram(nil, t, h, true)
if err != nil {
break
}
for vt := p.currDelIter.Next(); vt != chunkenc.ValNone; vt = p.currDelIter.Next() {
if vt != chunkenc.ValHistogram { if vt != chunkenc.ValHistogram {
err = fmt.Errorf("found value type %v in histogram chunk", vt) err = fmt.Errorf("found value type %v in histogram chunk", vt)
break break
} }
var h *histogram.Histogram
t, h = p.currDelIter.AtHistogram() t, h = p.currDelIter.AtHistogram()
_, _, app, err = app.AppendHistogram(nil, t, h, true) _, _, app, err = app.AppendHistogram(nil, t, h, true)
if err != nil { if err != nil {
@ -890,13 +895,18 @@ func (p *populateWithDelChunkSeriesIterator) Next() bool {
if app, err = newChunk.Appender(); err != nil { if app, err = newChunk.Appender(); err != nil {
break break
} }
var h *histogram.FloatHistogram
for vt := valueType; vt != chunkenc.ValNone; vt = p.currDelIter.Next() { t, h = p.currDelIter.AtFloatHistogram()
p.curr.MinTime = t
_, _, app, err = app.AppendFloatHistogram(nil, t, h, true)
if err != nil {
break
}
for vt := p.currDelIter.Next(); vt != chunkenc.ValNone; vt = p.currDelIter.Next() {
if vt != chunkenc.ValFloatHistogram { if vt != chunkenc.ValFloatHistogram {
err = fmt.Errorf("found value type %v in histogram chunk", vt) err = fmt.Errorf("found value type %v in histogram chunk", vt)
break break
} }
var h *histogram.FloatHistogram
t, h = p.currDelIter.AtFloatHistogram() t, h = p.currDelIter.AtFloatHistogram()
_, _, app, err = app.AppendFloatHistogram(nil, t, h, true) _, _, app, err = app.AppendFloatHistogram(nil, t, h, true)
if err != nil { if err != nil {