Merge pull request #15866 from arturmelanchyk/op-mem-alloc

promtool: optimize labels slice allocation
2025-02-02 08:31:11 -08:00 · 2025-01-27 11:00:56 +01:00 · 2025-01-27 11:00:56 +01:00 · 2830cbacb0
parent 2915b19773 30112f6ed7
commit 2830cbacb0
1 changed files with 1 additions and 2 deletions
--- a/cmd/promtool/tsdb.go
+++ b/cmd/promtool/tsdb.go
@ -315,12 +315,11 @@ func readPrometheusLabels(r io.Reader, n int) ([]labels.Labels, error) {
 	i := 0

 	for scanner.Scan() && i < n {
-		m := make([]labels.Label, 0, 10)
-
 		r := strings.NewReplacer("\"", "", "{", "", "}", "")
 		s := r.Replace(scanner.Text())

 		labelChunks := strings.Split(s, ",")
+		m := make([]labels.Label, 0, len(labelChunks))
 		for _, labelChunk := range labelChunks {
 			split := strings.Split(labelChunk, ":")
 			m = append(m, labels.Label{Name: split[0], Value: split[1]})