mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-26 06:04:05 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix strange code, add messages to code brought in #8106 (#13509)

Browse source 
Signed-off-by: Mikhail Fesenko <proggga@gmail.com>
This commit is contained in:
Mikhail Fesenko 2024-02-02 10:00:38 +01:00 committed by GitHub
parent 6feffeb92e
commit 419dd265cc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
tsdb/index/index.go
View file

@ -715,17 +715,11 @@ func (w *Writer) writeLabelIndexesOffsetTable() error {
} }
// Write out the length. // Write out the length.
w.buf1.Reset() err := w.writeLengthAndHash(startPos)
l := w.f.pos - startPos - 4 if err != nil {
if l > math.MaxUint32 { return fmt.Errorf("label indexes offset table length/crc32 write error: %w", err)
return fmt.Errorf("label indexes offset table size exceeds 4 bytes: %d", l)
} }
w.buf1.PutBE32int(int(l)) return nil
if err := w.writeAt(w.buf1.Get(), startPos); err != nil {
return err
}
return w.writeLenghtAndHash(startPos)
} }
// writePostingsOffsetTable writes the postings offset table. // writePostingsOffsetTable writes the postings offset table.
@ -793,25 +787,31 @@ func (w *Writer) writePostingsOffsetTable() error {
} }
w.fPO = nil w.fPO = nil
return w.writeLenghtAndHash(startPos) err = w.writeLengthAndHash(startPos)
if err != nil {
return fmt.Errorf("postings offset table length/crc32 write error: %w", err)
}
return nil
} }
func (w *Writer) writeLenghtAndHash(startPos uint64) error { func (w *Writer) writeLengthAndHash(startPos uint64) error {
// Write out the length.
w.buf1.Reset() w.buf1.Reset()
l := w.f.pos - startPos - 4 l := w.f.pos - startPos - 4
if l > math.MaxUint32 { if l > math.MaxUint32 {
return fmt.Errorf("postings offset table size exceeds 4 bytes: %d", l) return fmt.Errorf("length size exceeds 4 bytes: %d", l)
} }
w.buf1.PutBE32int(int(l)) w.buf1.PutBE32int(int(l))
if err := w.writeAt(w.buf1.Get(), startPos); err != nil { if err := w.writeAt(w.buf1.Get(), startPos); err != nil {
return err return fmt.Errorf("write length from buffer error: %w", err)
} }
// Write out the hash. // Write out the hash.
w.buf1.Reset() w.buf1.Reset()
w.buf1.PutHashSum(w.crc32) w.buf1.PutHashSum(w.crc32)
return w.write(w.buf1.Get()) if err := w.write(w.buf1.Get()); err != nil {
return fmt.Errorf("write buffer's crc32 error: %w", err)
}
return nil
} }
const indexTOCLen = 6*8 + crc32.Size const indexTOCLen = 6*8 + crc32.Size