mirror of
https://github.com/prometheus/prometheus.git
synced 2024-12-24 05:04:05 -08:00
promql: Remove unused Point.MarshalJSON method (#9860)
JSON marshaling is only needed for the HTTP API. Since Point is such a frequently marshaled type, it gets an optimized treatment directly in web/api/v1/api.go. The MarshalJSON method still provided in the promql package is therefore unused and its existence is confusing. Signed-off-by: beorn7 <beorn@grafana.com>
This commit is contained in:
parent
0e9d2aac2a
commit
427425cc9f
|
@ -77,6 +77,9 @@ func (s Series) String() string {
|
|||
}
|
||||
|
||||
// Point represents a single data point for a given timestamp.
|
||||
//
|
||||
// Note that Point's JSON marshaling is done in an optimized fashion in
|
||||
// web/api/v1/api.go. Therefore, no MarshalJSON method is provided here.
|
||||
type Point struct {
|
||||
T int64
|
||||
V float64
|
||||
|
@ -87,12 +90,6 @@ func (p Point) String() string {
|
|||
return fmt.Sprintf("%v @[%v]", v, p.T)
|
||||
}
|
||||
|
||||
// MarshalJSON implements json.Marshaler.
|
||||
func (p Point) MarshalJSON() ([]byte, error) {
|
||||
v := strconv.FormatFloat(p.V, 'f', -1, 64)
|
||||
return json.Marshal([...]interface{}{float64(p.T) / 1000, v})
|
||||
}
|
||||
|
||||
// Sample is a single sample belonging to a metric.
|
||||
type Sample struct {
|
||||
Point
|
||||
|
|
Loading…
Reference in a new issue