Show table alerts for limited series or disabled formatting

Signed-off-by: Julius Volz <julius.volz@gmail.com>
This commit is contained in:
Julius Volz 2024-07-30 10:48:18 +02:00
parent b06bb78543
commit 4343281c73

View file

@ -1,4 +1,11 @@
import { FC, ReactNode, useEffect, useId, useState } from "react"; import {
FC,
ReactNode,
useEffect,
useId,
useLayoutEffect,
useState,
} from "react";
import { import {
Table, Table,
Alert, Alert,
@ -10,6 +17,7 @@ import {
Group, Group,
Stack, Stack,
Text, Text,
Anchor,
} from "@mantine/core"; } from "@mantine/core";
import { IconAlertTriangle, IconInfoCircle } from "@tabler/icons-react"; import { IconAlertTriangle, IconInfoCircle } from "@tabler/icons-react";
import { import {
@ -30,12 +38,13 @@ import { useSettings } from "../../state/settingsSlice";
dayjs.extend(timezone); dayjs.extend(timezone);
const maxFormattableSeries = 1000; const maxFormattableSeries = 1000;
const maxDisplayableSeries = 10000; const maxDisplayableSeries = 1000;
const limitSeries = <S extends InstantSample | RangeSamples>( const limitSeries = <S extends InstantSample | RangeSamples>(
series: S[] series: S[],
limit: boolean
): S[] => { ): S[] => {
if (series.length > maxDisplayableSeries) { if (limit && series.length > maxDisplayableSeries) {
return series.slice(0, maxDisplayableSeries); return series.slice(0, maxDisplayableSeries);
} }
return series; return series;
@ -49,6 +58,7 @@ export interface DataTableProps {
const DataTable: FC<DataTableProps> = ({ expr, evalTime, retriggerIdx }) => { const DataTable: FC<DataTableProps> = ({ expr, evalTime, retriggerIdx }) => {
const [scale, setScale] = useState<string>("exponential"); const [scale, setScale] = useState<string>("exponential");
const [limitResults, setLimitResults] = useState<boolean>(true);
const { data, error, isFetching, isLoading, refetch } = const { data, error, isFetching, isLoading, refetch } =
useAPIQuery<InstantQueryResult>({ useAPIQuery<InstantQueryResult>({
@ -65,6 +75,10 @@ const DataTable: FC<DataTableProps> = ({ expr, evalTime, retriggerIdx }) => {
expr !== "" && refetch(); expr !== "" && refetch();
}, [retriggerIdx, refetch, expr, evalTime]); }, [retriggerIdx, refetch, expr, evalTime]);
useLayoutEffect(() => {
setLimitResults(true);
}, [data, isFetching]);
const { useLocalTime } = useSettings(); const { useLocalTime } = useSettings();
// Show a skeleton only on the first load, not on subsequent ones. // Show a skeleton only on the first load, not on subsequent ones.
@ -106,7 +120,34 @@ const DataTable: FC<DataTableProps> = ({ expr, evalTime, retriggerIdx }) => {
const doFormat = result.length <= maxFormattableSeries; const doFormat = result.length <= maxFormattableSeries;
console.log("rendering with", result.length, limitResults);
return ( return (
<>
{limitResults &&
["vector", "matrix"].includes(resultType) &&
result.length > maxDisplayableSeries && (
<Alert
color="red"
icon={<IconAlertTriangle size={14} />}
title="Showing limited results"
>
Fetched {data.data.result.length} metrics, only displaying first{" "}
{maxDisplayableSeries} for performance reasons.
<Anchor ml="md" fz="1em" onClick={() => setLimitResults(false)}>
Show all results
</Anchor>
</Alert>
)}
{!doFormat && (
<Alert
title="Formatting turned off"
icon={<IconInfoCircle size={14} />}
>
Showing more than {maxFormattableSeries} series, turning off label
formatting for performance reasons.
</Alert>
)}
<Box pos="relative" className={classes.tableWrapper}> <Box pos="relative" className={classes.tableWrapper}>
<LoadingOverlay <LoadingOverlay
visible={isFetching} visible={isFetching}
@ -120,7 +161,7 @@ const DataTable: FC<DataTableProps> = ({ expr, evalTime, retriggerIdx }) => {
<Table fz="xs"> <Table fz="xs">
<Table.Tbody> <Table.Tbody>
{resultType === "vector" ? ( {resultType === "vector" ? (
limitSeries<InstantSample>(result).map((s, idx) => ( limitSeries<InstantSample>(result, limitResults).map((s, idx) => (
<Table.Tr key={idx}> <Table.Tr key={idx}>
<Table.Td> <Table.Td>
<SeriesName labels={s.metric} format={doFormat} /> <SeriesName labels={s.metric} format={doFormat} />
@ -160,7 +201,7 @@ const DataTable: FC<DataTableProps> = ({ expr, evalTime, retriggerIdx }) => {
</Table.Tr> </Table.Tr>
)) ))
) : resultType === "matrix" ? ( ) : resultType === "matrix" ? (
limitSeries<RangeSamples>(result).map((s, idx) => ( limitSeries<RangeSamples>(result, limitResults).map((s, idx) => (
<Table.Tr key={idx}> <Table.Tr key={idx}>
<Table.Td> <Table.Td>
<SeriesName labels={s.metric} format={doFormat} /> <SeriesName labels={s.metric} format={doFormat} />
@ -205,6 +246,7 @@ const DataTable: FC<DataTableProps> = ({ expr, evalTime, retriggerIdx }) => {
</Table.Tbody> </Table.Tbody>
</Table> </Table>
</Box> </Box>
</>
); );
}; };