From 46b84ab3fbc346e78a6cdb58ff108843b2e77129 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicol=C3=A1s=20Pazos?= <npazosmendez@gmail.com>
Date: Tue, 31 Oct 2023 09:52:55 -0300
Subject: [PATCH] lint

---
 storage/remote/queue_manager.go      |  1 +
 storage/remote/queue_manager_test.go | 33 ----------------------------
 storage/remote/write.go              |  1 -
 storage/remote/write_handler_test.go |  2 +-
 4 files changed, 2 insertions(+), 35 deletions(-)

diff --git a/storage/remote/queue_manager.go b/storage/remote/queue_manager.go
index 04ecb9181e..497b6986bb 100644
--- a/storage/remote/queue_manager.go
+++ b/storage/remote/queue_manager.go
@@ -1493,6 +1493,7 @@ func populateTimeSeries(batch []timeSeries, pendingData []prompb.TimeSeries, sen
 	}
 	return nPendingSamples, nPendingExemplars, nPendingHistograms
 }
+
 func (s *shards) sendSamples(ctx context.Context, samples []prompb.TimeSeries, sampleCount, exemplarCount, histogramCount int, pBuf *proto.Buffer, buf *[]byte) {
 	begin := time.Now()
 	// Build the WriteRequest with no metadata.
diff --git a/storage/remote/queue_manager_test.go b/storage/remote/queue_manager_test.go
index 4018090f12..73488de0e7 100644
--- a/storage/remote/queue_manager_test.go
+++ b/storage/remote/queue_manager_test.go
@@ -619,38 +619,6 @@ func createTimeseries(numSamples, numSeries int, extraLabels ...labels.Label) ([
 	return samples, series
 }
 
-func createDummyTimeseriesBatch(numSeries int, extraLabels ...labels.Label) []timeSeries {
-	result := make([]timeSeries, numSeries)
-	for i := range result {
-		name := fmt.Sprintf("test_metric_%d", i)
-		rand.Shuffle(len(extraLabels), func(i, j int) {
-			extraLabels[i], extraLabels[j] = extraLabels[j], extraLabels[i]
-		})
-		result[i] = timeSeries{
-			seriesLabels: labels.NewBuilder(extraLabels[0:3]).Set(labels.MetricName, name).Labels(),
-			timestamp:    int64(i),
-		}
-		switch i % 10 {
-		case 0, 1, 2, 3, 4, 5:
-			result[i].value = float64(i)
-		case 6:
-			result[i].exemplarLabels = extraLabels
-			result[i].value = float64(i)
-		case 7:
-			result[i].histogram = &histogram.Histogram{
-				Schema:        2,
-				ZeroThreshold: 1e-128,
-			}
-		case 8, 9:
-			result[i].floatHistogram = &histogram.FloatHistogram{
-				Schema:        2,
-				ZeroThreshold: 1e-128,
-			}
-		}
-	}
-	return result
-}
-
 func createExemplars(numExemplars, numSeries int) ([]record.RefExemplar, []record.RefSeries) {
 	exemplars := make([]record.RefExemplar, 0, numExemplars)
 	series := make([]record.RefSeries, 0, numSeries)
@@ -1478,7 +1446,6 @@ func createDummyTimeSeries(instances int) []timeSeries {
 
 func BenchmarkBuildWriteRequest(b *testing.B) {
 	bench := func(b *testing.B, batch []timeSeries) {
-
 		buff := make([]byte, 0)
 		seriesBuff := make([]prompb.TimeSeries, len(batch))
 		for i := range seriesBuff {
diff --git a/storage/remote/write.go b/storage/remote/write.go
index 9b506d620b..a9239504bc 100644
--- a/storage/remote/write.go
+++ b/storage/remote/write.go
@@ -165,7 +165,6 @@ func (rws *WriteStorage) ApplyConfig(conf *config.Config) error {
 			Headers:          rwConf.Headers,
 			RetryOnRateLimit: rwConf.QueueConfig.RetryOnRateLimit,
 		})
-
 		if err != nil {
 			return err
 		}
diff --git a/storage/remote/write_handler_test.go b/storage/remote/write_handler_test.go
index 5bdedb9ef1..e5df983eca 100644
--- a/storage/remote/write_handler_test.go
+++ b/storage/remote/write_handler_test.go
@@ -182,7 +182,7 @@ func BenchmarkRemoteWritehandler(b *testing.B) {
 	}
 }
 
-// TODO(npazosmendez): add benchmarks with realistc scenarios
+// TODO(npazosmendez): add benchmarks with realistic scenarios
 func BenchmarkReducedRemoteWriteHandler(b *testing.B) {
 	const labelValue = "abcdefg'hijlmn234!@#$%^&*()_+~`\"{}[],./<>?hello0123hiOlá你好Dzieńdobry9Zd8ra765v4stvuyte"
 	reqs := []*http.Request{}