mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-25 13:44:05 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #2874 from prometheus/memleak

Browse source 
retrieval: fix memory leak in scrape cache
This commit is contained in:
Fabian Reinartz 2017-06-26 15:21:35 +02:00 committed by GitHub
parent ca2b68889b 2368d2c45b
commit 4b70318d11
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
retrieval/scrape.go
View file

@ -508,6 +508,11 @@ func (c *scrapeCache) getRef(met string) (string, bool) {
} }
func (c *scrapeCache) addRef(met, ref string, lset labels.Labels) { func (c *scrapeCache) addRef(met, ref string, lset labels.Labels) {
// Clean up the label set cache before overwriting the ref for a previously seen
// metric representation. It won't be caught by the cleanup in iterDone otherwise.
if e, ok := c.refs[met]; ok {
delete(c.lsets, e.ref)
}
c.refs[met] = &refEntry{ref: ref, lastIter: c.iter} c.refs[met] = &refEntry{ref: ref, lastIter: c.iter}
// met is the raw string the metric was ingested as. The label set is not ordered // met is the raw string the metric was ingested as. The label set is not ordered
// and thus it's not suitable to uniquely identify cache entries. // and thus it's not suitable to uniquely identify cache entries.