client test comment nits.

This commit is contained in:
Krasi Georgiev 2018-01-22 21:15:52 +00:00
parent 66bcb10f40
commit 4d47a48422

View file

@ -289,13 +289,13 @@ func TestBearerAuthRoundTripper(t *testing.T) {
} }
}, nil, nil) }, nil, nil)
//Normal flow // Normal flow.
bearerAuthRoundTripper := NewBearerAuthRoundTripper(BearerToken, fakeRoundTripper) bearerAuthRoundTripper := NewBearerAuthRoundTripper(BearerToken, fakeRoundTripper)
request, _ := http.NewRequest("GET", "/hitchhiker", nil) request, _ := http.NewRequest("GET", "/hitchhiker", nil)
request.Header.Set("User-Agent", "Douglas Adams mind") request.Header.Set("User-Agent", "Douglas Adams mind")
bearerAuthRoundTripper.RoundTrip(request) bearerAuthRoundTripper.RoundTrip(request)
//Should honor already Authorization header set // Should honor already Authorization header set.
bearerAuthRoundTripperShouldNotModifyExistingAuthorization := NewBearerAuthRoundTripper(newBearerToken, fakeRoundTripper) bearerAuthRoundTripperShouldNotModifyExistingAuthorization := NewBearerAuthRoundTripper(newBearerToken, fakeRoundTripper)
request, _ = http.NewRequest("GET", "/hitchhiker", nil) request, _ = http.NewRequest("GET", "/hitchhiker", nil)
request.Header.Set("Authorization", ExpectedBearer) request.Header.Set("Authorization", ExpectedBearer)
@ -315,13 +315,13 @@ func TestBearerAuthFileRoundTripper(t *testing.T) {
} }
}, nil, nil) }, nil, nil)
//Normal flow // Normal flow.
bearerAuthRoundTripper := NewBearerAuthFileRoundTripper(BearerTokenFile, fakeRoundTripper) bearerAuthRoundTripper := NewBearerAuthFileRoundTripper(BearerTokenFile, fakeRoundTripper)
request, _ := http.NewRequest("GET", "/hitchhiker", nil) request, _ := http.NewRequest("GET", "/hitchhiker", nil)
request.Header.Set("User-Agent", "Douglas Adams mind") request.Header.Set("User-Agent", "Douglas Adams mind")
bearerAuthRoundTripper.RoundTrip(request) bearerAuthRoundTripper.RoundTrip(request)
//Should honor already Authorization header set // Should honor already Authorization header set.
bearerAuthRoundTripperShouldNotModifyExistingAuthorization := NewBearerAuthFileRoundTripper(MissingBearerTokenFile, fakeRoundTripper) bearerAuthRoundTripperShouldNotModifyExistingAuthorization := NewBearerAuthFileRoundTripper(MissingBearerTokenFile, fakeRoundTripper)
request, _ = http.NewRequest("GET", "/hitchhiker", nil) request, _ = http.NewRequest("GET", "/hitchhiker", nil)
request.Header.Set("Authorization", ExpectedBearer) request.Header.Set("Authorization", ExpectedBearer)
@ -347,14 +347,14 @@ func TestBasicAuthRoundTripper(t *testing.T) {
} }
}, nil, nil) }, nil, nil)
//Normal flow // Normal flow.
basicAuthRoundTripper := NewBasicAuthRoundTripper(ExpectedUsername, basicAuthRoundTripper := NewBasicAuthRoundTripper(ExpectedUsername,
ExpectedPassword, fakeRoundTripper) ExpectedPassword, fakeRoundTripper)
request, _ := http.NewRequest("GET", "/hitchhiker", nil) request, _ := http.NewRequest("GET", "/hitchhiker", nil)
request.Header.Set("User-Agent", "Douglas Adams mind") request.Header.Set("User-Agent", "Douglas Adams mind")
basicAuthRoundTripper.RoundTrip(request) basicAuthRoundTripper.RoundTrip(request)
//Should honor already Authorization header set // Should honor already Authorization header set.
basicAuthRoundTripperShouldNotModifyExistingAuthorization := NewBasicAuthRoundTripper(newUsername, basicAuthRoundTripperShouldNotModifyExistingAuthorization := NewBasicAuthRoundTripper(newUsername,
newPassword, fakeRoundTripper) newPassword, fakeRoundTripper)
request, _ = http.NewRequest("GET", "/hitchhiker", nil) request, _ = http.NewRequest("GET", "/hitchhiker", nil)