From 502aa9ded553f2b59f55e26db08374c1cc1d25d8 Mon Sep 17 00:00:00 2001 From: beorn7 Date: Thu, 16 Jul 2015 12:25:32 +0200 Subject: [PATCH] Use Has instead of Get for existence test. --- storage/local/index/leveldb.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/storage/local/index/leveldb.go b/storage/local/index/leveldb.go index 37630b8b3e..c4c46421cd 100644 --- a/storage/local/index/leveldb.go +++ b/storage/local/index/leveldb.go @@ -110,12 +110,8 @@ func (l *LevelDB) Delete(key encoding.BinaryMarshaler) (bool, error) { return false, err } // Note that Delete returns nil if k does not exist. So we have to test - // for existence with Get first. - _, err = l.storage.Get(k, l.readOpts) - if err == leveldb.ErrNotFound { - return false, nil - } - if err != nil { + // for existence with Has first. + if has, err := l.storage.Has(k, l.readOpts); !has || err != nil { return false, err } if err = l.storage.Delete(k, l.writeOpts); err != nil {