mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

skip reloader in failing test

Browse source 
Signed-off-by: Lovro Mažgon <lovro.mazgon@gmail.com>
This commit is contained in:
Lovro Mažgon 2024-05-09 13:55:48 +02:00
parent d60f34a324
commit 582753daa8
No known key found for this signature in database
GPG key ID: A8554FEB34E8BC79
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
scrape/manager.go
View file

@ -87,8 +87,9 @@ type Options struct {
// Optional HTTP client options to use when scraping. // Optional HTTP client options to use when scraping.
HTTPClientOptions []config_util.HTTPClientOption HTTPClientOptions []config_util.HTTPClientOption
// private option for testability. // private options for testability.
skipOffsetting bool skipOffsetting bool
skipReloader bool
} }
// Manager maintains a set of scrape pools and manages start/stop cycles // Manager maintains a set of scrape pools and manages start/stop cycles
@ -114,7 +115,9 @@ type Manager struct {
// Run receives and saves target set updates and triggers the scraping loops reloading. // Run receives and saves target set updates and triggers the scraping loops reloading.
// Reloading happens in the background so that it doesn't block receiving targets updates. // Reloading happens in the background so that it doesn't block receiving targets updates.
func (m *Manager) Run(tsets <-chan map[string][]*targetgroup.Group) error { func (m *Manager) Run(tsets <-chan map[string][]*targetgroup.Group) error {
go m.reloader() if !m.opts.skipReloader {
go m.reloader()
}
for { for {
select { select {
case ts := <-tsets: case ts := <-tsets:

2
scrape/manager_test.go
View file

@ -572,7 +572,7 @@ scrape_configs:
} }
func TestManagerTargetsUpdates(t *testing.T) { func TestManagerTargetsUpdates(t *testing.T) {
opts := Options{} opts := Options{skipReloader: true}
testRegistry := prometheus.NewRegistry() testRegistry := prometheus.NewRegistry()
m, err := NewManager(&opts, nil, nil, testRegistry) m, err := NewManager(&opts, nil, nil, testRegistry)
require.NoError(t, err) require.NoError(t, err)