mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-15 01:54:06 -08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fix error reported by asyncBlockWriter.addSeries()

Browse source 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
This commit is contained in:
Marco Pracucci 2022-02-10 15:07:13 +01:00
parent cd86e92b74
commit 583e746a82
No known key found for this signature in database
GPG key ID: 74C1BD403D2DF9B5
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
tsdb/async_block_writer.go
View file

@ -2,7 +2,6 @@ package tsdb
import (
"context"
"fmt"
"github.com/pkg/errors"
"go.uber.org/atomic"
@ -14,6 +13,10 @@ import (
"github.com/prometheus/prometheus/tsdb/chunks"
)
var (
errAsyncBlockWriterNotRunning = errors.New("asyncBlockWriter doesn't run anymore")
)
// asyncBlockWriter runs a background goroutine that writes series and chunks to the block asynchronously.
type asyncBlockWriter struct {
chunkPool chunkenc.Pool // Where to return chunks after writing.
@ -111,7 +114,14 @@ func (bw *asyncBlockWriter) addSeries(lbls labels.Labels, chks []chunks.Meta) er
if ok {
bw.result = result
}
return fmt.Errorf("asyncBlockWriter doesn't run anymore")
// If the writer isn't running anymore because of an error occurred in loop()
// then we should return that error too, otherwise it may be never reported
// and we'll never know the actual root cause.
if bw.result.err != nil {
return errors.Wrap(bw.result.err, errAsyncBlockWriterNotRunning.Error())
}
return errAsyncBlockWriterNotRunning
}
}