mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-13 06:47:28 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Added rule name to rule error for easier debugging (#3549)

Browse source
This commit is contained in:
Conor Broderick 2017-12-06 15:39:06 +00:00 committed by Brian Brazil
parent 30b4439bbd
commit 59d4c539d1
1 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
pkg/rulefmt/rulefmt.go
View file

@ -28,11 +28,12 @@ import (
type Error struct {
Group string
Rule int
RuleName string
Err error
}
func (err *Error) Error() string {
return errors.Wrapf(err.Err, "group %q, rule %d", err.Group, err.Rule).Error()
return errors.Wrapf(err.Err, "group %q, rule %d, %q", err.Group, err.Rule, err.RuleName).Error()
}
// RuleGroups is a set of rule groups that are typically exposed in a file.
@ -67,9 +68,16 @@ func (g *RuleGroups) Validate() (errs []error) {
for i, r := range g.Rules {
for _, err := range r.Validate() {
var ruleName string
if r.Alert != "" {
ruleName = r.Alert
} else {
ruleName = r.Record
}
errs = append(errs, &Error{
Group: g.Name,
Rule: i,
RuleName: ruleName,
Err: err,
})
}