mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

config: set gogc default value when config body is empty (#16052)

Browse source 
* fix: set gogc default value when config body is empty

Signed-off-by: Danial Eskandari <doneskandari@gmail.com>

* refactor: explicitly check value 75 in `TestGoGCDefaultValueOnEmptyConfigBody`

add GoGC assertion in `TestEmptyConfig`, also removed the no longer needed runtime config assignment in `TestEmptyGlobalBlock`

Signed-off-by: Danial Eskandari <doneskandari@gmail.com>

* refactor: remove `TestGoGCDefaultValueOnEmptyConfigBody` to reduce duplicate assertions

Signed-off-by: Danial Eskandari <doneskandari@gmail.com>

---------

Signed-off-by: Danial Eskandari <doneskandari@gmail.com>
This commit is contained in:
Danial Eskandari 2025-02-27 13:55:52 +03:30 committed by GitHub
parent d72c1ec2c2
commit 5efaa84be1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
config/config.go
View file

@ -156,6 +156,7 @@ var (
// DefaultConfig is the default top-level configuration. // DefaultConfig is the default top-level configuration.
DefaultConfig = Config{ DefaultConfig = Config{
GlobalConfig: DefaultGlobalConfig, GlobalConfig: DefaultGlobalConfig,
Runtime: DefaultRuntimeConfig,
} }
// DefaultGlobalConfig is the default global configuration. // DefaultGlobalConfig is the default global configuration.

2
config/config_test.go
View file

@ -2222,6 +2222,7 @@ func TestEmptyConfig(t *testing.T) {
exp := DefaultConfig exp := DefaultConfig
exp.loaded = true exp.loaded = true
require.Equal(t, exp, *c) require.Equal(t, exp, *c)
require.Equal(t, 75, c.Runtime.GoGC)
} }
func TestExpandExternalLabels(t *testing.T) { func TestExpandExternalLabels(t *testing.T) {
@ -2269,7 +2270,6 @@ func TestEmptyGlobalBlock(t *testing.T) {
c, err := Load("global:\n", promslog.NewNopLogger()) c, err := Load("global:\n", promslog.NewNopLogger())
require.NoError(t, err) require.NoError(t, err)
exp := DefaultConfig exp := DefaultConfig
exp.Runtime = DefaultRuntimeConfig
exp.loaded = true exp.loaded = true
require.Equal(t, exp, *c) require.Equal(t, exp, *c)
} }