From 611f50bb3d362e07f5a98a6f806e7826b21e3f47 Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Sun, 20 Aug 2023 14:30:36 +0100 Subject: [PATCH] scrape: retain all dropped targets when KeepDroppedTargets is zero This was a bug. Signed-off-by: Bryan Boreham --- scrape/scrape.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scrape/scrape.go b/scrape/scrape.go index 40836afc20..b52616a01a 100644 --- a/scrape/scrape.go +++ b/scrape/scrape.go @@ -529,7 +529,7 @@ func (sp *scrapePool) Sync(tgs []*targetgroup.Group) { case nonEmpty: all = append(all, t) case !t.discoveredLabels.IsEmpty(): - if sp.config.KeepDroppedTargets != 0 && uint(len(sp.droppedTargets)) < sp.config.KeepDroppedTargets { + if sp.config.KeepDroppedTargets == 0 || uint(len(sp.droppedTargets)) < sp.config.KeepDroppedTargets { sp.droppedTargets = append(sp.droppedTargets, t) } sp.droppedTargetsCount++