mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-12 14:27:27 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

optimize regex matching for empty label values in posting match (#14075)

Browse source 
Also update tests.

Signed-off-by: Ben Ye <benye@amazon.com>
This commit is contained in:
Ben Ye 2024-05-29 08:03:33 -07:00 committed by GitHub
parent a6316a5dcb
commit 6683895620
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tsdb/querier.go
View file

@ -357,8 +357,8 @@ func inversePostingsForMatcher(ctx context.Context, ix IndexReader, m *labels.Ma
} }
res := vals[:0] res := vals[:0]
// If the inverse match is ="", we just want all the values. // If the match before inversion was !="" or !~"", we just want all the values.
if m.Type == labels.MatchEqual && m.Value == "" { if m.Value == "" && (m.Type == labels.MatchRegexp || m.Type == labels.MatchEqual) {
res = vals res = vals
} else { } else {
count := 1 count := 1

7
tsdb/querier_test.go
View file

@ -2808,6 +2808,13 @@ func TestPostingsForMatchers(t *testing.T) {
}, },
}, },
// Not regex. // Not regex.
{
matchers: []*labels.Matcher{labels.MustNewMatcher(labels.MatchNotRegexp, "i", "")},
exp: []labels.Labels{
labels.FromStrings("n", "1", "i", "a"),
labels.FromStrings("n", "1", "i", "b"),
},
},
{ {
matchers: []*labels.Matcher{labels.MustNewMatcher(labels.MatchNotRegexp, "n", "^1$")}, matchers: []*labels.Matcher{labels.MustNewMatcher(labels.MatchNotRegexp, "n", "^1$")},
exp: []labels.Labels{ exp: []labels.Labels{