Reduce memory allocation in benchmarkIterator() (#5983)

Previously it was allocating millions of chunks, all containing the
same 250 samples.  Above some ratio of CPU performance to available
memory, the benchmark cannot run.

Make 250 a const and just allocate one chunk which we iterate
repeatedly till we reach the benchmark count.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

tsdb/chunkenc/chunk_test.go

@@ -110,12 +110,13 @@ func testChunk(t *testing.T, c Chunk) {
 }
 
 func benchmarkIterator(b *testing.B, newChunk func() Chunk) {
+	const samplesPerChunk = 250
 	var (
 		t   = int64(1234123324)
 		v   = 1243535.123
 		exp []pair
 	)
-	for i := 0; i < b.N; i++ {
+	for i := 0; i < samplesPerChunk; i++ {
 		// t += int64(rand.Intn(10000) + 1)
 		t += int64(1000)
 		// v = rand.Float64()
@@ -123,11 +124,9 @@ func benchmarkIterator(b *testing.B, newChunk func() Chunk) {
 		exp = append(exp, pair{t: t, v: v})
 	}
 
-	var chunks []Chunk
+	chunk := newChunk()
-	for i := 0; i < b.N; {
+	{
-		c := newChunk()
+		a, err := chunk.Appender()
-
-		a, err := c.Appender()
 		if err != nil {
 			b.Fatalf("get appender: %s", err)
 		}
@@ -137,32 +136,27 @@ func benchmarkIterator(b *testing.B, newChunk func() Chunk) {
 				break
 			}
 			a.Append(p.t, p.v)
-			i++
 			j++
 		}
-		chunks = append(chunks, c)
 	}
 
 	b.ReportAllocs()
 	b.ResetTimer()
 
-	b.Log("num", b.N, "created chunks", len(chunks))
+	var res float64
-
-	res := make([]float64, 0, 1024)
-
 	var it Iterator
-	for i := 0; i < len(chunks); i++ {
+	for i := 0; i < b.N; {
-		c := chunks[i]
+		it := chunk.Iterator(it)
-		it := c.Iterator(it)
 
 		for it.Next() {
 			_, v := it.At()
-			res = append(res, v)
+			res = v
+			i++
 		}
 		if it.Err() != io.EOF {
 			require.NoError(b, it.Err())
 		}
-		res = res[:0]
+		_ = res
 	}
 }