mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-10 07:34:04 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix missing printed keep_common without grouping.

Browse source
This commit is contained in:
Julius Volz 2016-04-15 19:48:17 +02:00
parent 096a2ef200
commit 6ac39700ea
2 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
promql/printer.go
View file

@ -143,10 +143,10 @@ func (node *AggregateExpr) String() string {
} else {
format = "%s BY (%s)"
}
if node.KeepExtraLabels {
format += " KEEP_COMMON"
aggrString = fmt.Sprintf(format, aggrString, node.Grouping)
}
return fmt.Sprintf(format, aggrString, node.Grouping)
if node.KeepExtraLabels {
aggrString += " KEEP_COMMON"
}
return aggrString
}

3
promql/printer_test.go
View file

@ -30,6 +30,9 @@ func TestExprString(t *testing.T) {
{
in: `sum(task:errors:rate10s{job="s"}) BY (code) KEEP_COMMON`,
},
{
in: `sum(task:errors:rate10s{job="s"}) KEEP_COMMON`,
},
{
in: `sum(task:errors:rate10s{job="s"}) WITHOUT (instance)`,
},