Merge pull request #595 from prometheus/show-special-values-as-gaps

Show special float values as gaps.
This commit is contained in:
Julius Volz 2015-03-14 03:29:58 +01:00
commit 6b0ef506f3
2 changed files with 12 additions and 2 deletions

View file

@ -385,7 +385,8 @@ Prometheus.Graph.prototype.metricToTsName = function(labels) {
Prometheus.Graph.prototype.parseValue = function(value) {
if (value == "NaN" || value == "Inf" || value == "-Inf") {
return 0; // TODO: what should we really do here?
// Can't display these values on a graph, so display a gap instead.
return null;
} else {
return parseFloat(value);
}

View file

@ -376,6 +376,15 @@ PromConsole.Graph = function(params) {
};
PromConsole.Graph.prototype._parseValue = function(value) {
if (value == "NaN" || value == "Inf" || value == "-Inf") {
// Can't display these values on a graph, so display a gap instead.
return null;
} else {
return parseFloat(value);
}
}
PromConsole.Graph.prototype._render = function(data) {
var palette = new Rickshaw.Color.Palette();
var series = [];
@ -399,7 +408,7 @@ PromConsole.Graph.prototype._render = function(data) {
for (var e = 0; e < data.length; e++) {
for (var i = 0; i < data[e].value.length; i++) {
series[seriesLen++] = {
data: data[e].value[i].values.map(function(s) {return {x: s[0], y: parseFloat(s[1])} }),
data: data[e].value[i].values.map(function(s) {return {x: s[0], y: self._parseValue(s[1])} }),
color: palette.color(),
name: nameFunc(data[e].value[i].metric),
};