mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-13 06:47:28 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

cmd/prometheus: buffer signal chans

Browse source 
According to the GoDoc for os.Signal [0]:

> Package signal will not block sending to c: the caller must ensure that
> c has sufficient buffer space to keep up with the expected signal rate.
> For a channel used for notification of just one signal value, a buffer
> of size 1 is sufficient.

[0] https://golang.org/pkg/os/signal/#Notify

Signed-off-by: Lucas Serven <lserven@gmail.com>
This commit is contained in:
Lucas Serven 2018-11-14 09:56:42 +01:00
parent 181f07ef26
commit 70c8b2c63c
No known key found for this signature in database
GPG key ID: 586FEAF680DA74AD
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cmd/prometheus/main.go
View file

@ -395,7 +395,7 @@ func main() {
var g group.Group var g group.Group
{ {
// Termination handler. // Termination handler.
term := make(chan os.Signal) term := make(chan os.Signal, 1)
signal.Notify(term, os.Interrupt, syscall.SIGTERM) signal.Notify(term, os.Interrupt, syscall.SIGTERM)
cancel := make(chan struct{}) cancel := make(chan struct{})
g.Add( g.Add(
@ -474,7 +474,7 @@ func main() {
// Make sure that sighup handler is registered with a redirect to the channel before the potentially // Make sure that sighup handler is registered with a redirect to the channel before the potentially
// long and synchronous tsdb init. // long and synchronous tsdb init.
hup := make(chan os.Signal) hup := make(chan os.Signal, 1)
signal.Notify(hup, syscall.SIGHUP) signal.Notify(hup, syscall.SIGHUP)
cancel := make(chan struct{}) cancel := make(chan struct{})
g.Add( g.Add(