mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-27 22:49:40 -08:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Merge pull request #2021 from prometheus/beorn7/storage

Browse source 
Avoid `defer` in seriesMap.get
This commit is contained in:
Fabian Reinartz 2016-09-22 18:12:21 +02:00 committed by GitHub
parent 2ee00b4461 ca98382943
commit 71b332278d
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
storage/local/series.go
View file

@ -66,9 +66,11 @@ func (sm *seriesMap) length() int {
// semantics as the native Go map.
func (sm *seriesMap) get(fp model.Fingerprint) (s *memorySeries, ok bool) {
sm.mtx.RLock()
defer sm.mtx.RUnlock()
s, ok = sm.m[fp]
// Note that the RUnlock is not done via defer for performance reasons.
// TODO(beorn7): Once https://github.com/golang/go/issues/14939 is
// fixed, revert to the usual defer idiom.
sm.mtx.RUnlock()
return
}