mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

scrape/scrape_test.go: reduce the time it takes to reload the manager (#14447)

Browse source 
* scrape/scrape_test.go: reduce the time it takes to reload the manager

TestNativeHistogramMaxSchemaSet took over 3x5s to complete because
there's a minimum reload interval.

I've made the testcases run in parallel and reduced the reload interval
to 10ms. Now the test runs in around 0.1-0.2 seconds.

Ran test 10000 times to check if it's flaky.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

---------

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This commit is contained in:
George Krajcsovits 2024-09-26 18:35:15 +02:00 committed by GitHub
parent d5f65cfce0
commit 79a6238e19
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
scrape/scrape_test.go
View file

@ -3773,7 +3773,9 @@ func TestNativeHistogramMaxSchemaSet(t *testing.T) {
}, },
} }
for name, tc := range testcases { for name, tc := range testcases {
tc := tc
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {
t.Parallel()
testNativeHistogramMaxSchemaSet(t, tc.minBucketFactor, tc.expectedSchema) testNativeHistogramMaxSchemaSet(t, tc.minBucketFactor, tc.expectedSchema)
}) })
} }
@ -3816,8 +3818,8 @@ func testNativeHistogramMaxSchemaSet(t *testing.T, minBucketFactor string, expec
configStr := fmt.Sprintf(` configStr := fmt.Sprintf(`
global: global:
metric_name_validation_scheme: legacy metric_name_validation_scheme: legacy
scrape_interval: 1s scrape_interval: 50ms
scrape_timeout: 1s scrape_timeout: 25ms
scrape_configs: scrape_configs:
- job_name: test - job_name: test
%s %s
@ -3830,7 +3832,7 @@ scrape_configs:
s.DB.EnableNativeHistograms() s.DB.EnableNativeHistograms()
reg := prometheus.NewRegistry() reg := prometheus.NewRegistry()
mng, err := NewManager(&Options{EnableNativeHistogramsIngestion: true}, nil, nil, s, reg) mng, err := NewManager(&Options{DiscoveryReloadInterval: model.Duration(10 * time.Millisecond), EnableNativeHistogramsIngestion: true}, nil, nil, s, reg)
require.NoError(t, err) require.NoError(t, err)
cfg, err := config.Load(configStr, false, log.NewNopLogger()) cfg, err := config.Load(configStr, false, log.NewNopLogger())
require.NoError(t, err) require.NoError(t, err)
@ -3861,7 +3863,7 @@ scrape_configs:
countSeries++ countSeries++
} }
return countSeries > 0 return countSeries > 0
}, 15*time.Second, 100*time.Millisecond) }, 5*time.Second, 100*time.Millisecond)
// Check that native histogram schema is as expected. // Check that native histogram schema is as expected.
q, err := s.Querier(0, math.MaxInt64) q, err := s.Querier(0, math.MaxInt64)