mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-25 05:34:05 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix(remote): rename some remote read related metrics for better clarity.

Browse source 
From the remote read handler side:

prometheus_api_remote_read_queries -> prometheus_remote_read_handler_queries

From the remote read client side:

prometheus_remote_storage_read_queries_total -> prometheus_remote_read_client_queries_total
prometheus_remote_storage_remote_read_queries -> prometheus_remote_read_client_queries
prometheus_remote_storage_read_request_duration_seconds -> prometheus_remote_read_client_request_duration_seconds

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
This commit is contained in:
machine424 2024-12-05 13:28:15 +01:00
parent af2a1cb10c
commit 7aa1f4571b
No known key found for this signature in database
GPG key ID: A4B001A4FDEE017D
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
storage/remote/client.go
View file

@ -81,8 +81,8 @@ var (
remoteReadQueriesTotal = prometheus.NewCounterVec( remoteReadQueriesTotal = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Namespace: namespace, Namespace: namespace,
Subsystem: subsystem, Subsystem: "remote_read_client",
Name: "read_queries_total", Name: "queries_total",
Help: "The total number of remote read queries.", Help: "The total number of remote read queries.",
}, },
[]string{remoteName, endpoint, "response_type", "code"}, []string{remoteName, endpoint, "response_type", "code"},
@ -90,8 +90,8 @@ var (
remoteReadQueries = prometheus.NewGaugeVec( remoteReadQueries = prometheus.NewGaugeVec(
prometheus.GaugeOpts{ prometheus.GaugeOpts{
Namespace: namespace, Namespace: namespace,
Subsystem: subsystem, Subsystem: "remote_read_client",
Name: "remote_read_queries", Name: "queries",
Help: "The number of in-flight remote read queries.", Help: "The number of in-flight remote read queries.",
}, },
[]string{remoteName, endpoint}, []string{remoteName, endpoint},
@ -99,8 +99,8 @@ var (
remoteReadQueryDuration = prometheus.NewHistogramVec( remoteReadQueryDuration = prometheus.NewHistogramVec(
prometheus.HistogramOpts{ prometheus.HistogramOpts{
Namespace: namespace, Namespace: namespace,
Subsystem: subsystem, Subsystem: "remote_read_client",
Name: "read_request_duration_seconds", Name: "request_duration_seconds",
Help: "Histogram of the latency for remote read requests. Note that for streamed responses this is only the duration of the initial call and does not include the processing of the stream.", Help: "Histogram of the latency for remote read requests. Note that for streamed responses this is only the duration of the initial call and does not include the processing of the stream.",
Buckets: append(prometheus.DefBuckets, 25, 60), Buckets: append(prometheus.DefBuckets, 25, 60),
NativeHistogramBucketFactor: 1.1, NativeHistogramBucketFactor: 1.1,

8
storage/remote/read_handler.go
View file

@ -56,10 +56,10 @@ func NewReadHandler(logger *slog.Logger, r prometheus.Registerer, queryable stor
marshalPool: &sync.Pool{}, marshalPool: &sync.Pool{},
queries: prometheus.NewGauge(prometheus.GaugeOpts{ queries: prometheus.NewGauge(prometheus.GaugeOpts{
Namespace: "prometheus", Namespace: namespace,
Subsystem: "api", // TODO: changes to storage in Prometheus 3.0. Subsystem: "remote_read_handler",
Name: "remote_read_queries", Name: "queries",
Help: "The current number of remote read queries being executed or waiting.", Help: "The current number of remote read queries that are either in execution or queued on the handler.",
}), }),
} }
if r != nil { if r != nil {