mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-11-10 07:34:04 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Use '.' instead of '=' to separate labels from their values in Graphite

Browse source 
Using .label=value. was weird to use in Graphite and didn't bring much value.
This commit is contained in:
Corentin Chary 2016-01-11 13:56:10 +01:00
parent 37d28bf91a
commit 7b6c3e556c
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
storage/remote/graphite/client.go
View file

@ -63,11 +63,11 @@ func pathFromMetric(m model.Metric, prefix string) string {
if l == model.MetricNameLabel || len(l) == 0 {
continue
}
// Here we use '=' instead of '.' to be able
// to later read back the value correctly. Using '.' would
// not allow to distinguish labels from values.
// Since we use '.' instead of '=' to separate label and values
// it means that we can't have an '.' in the metric name. Fortunately
// this is prohibited in prometheus metrics.
buffer.WriteString(fmt.Sprintf(
".%s=%s", string(l), escape(v)))
".%s.%s", string(l), escape(v)))
}
return buffer.String()
}

4
storage/remote/graphite/client_test.go
View file

@ -48,8 +48,8 @@ func TestEscape(t *testing.T) {
func TestPathFromMetric(t *testing.T) {
expected := ("prefix." +
"test:metric" +
".many_chars=abc!ABC:012-3!45%C3%B667~89%2E%2F\\(\\)\\{\\}\\,%3D%2E\\\"\\\\" +
".testlabel=test:value")
".many_chars.abc!ABC:012-3!45%C3%B667~89%2E%2F\\(\\)\\{\\}\\,%3D%2E\\\"\\\\" +
".testlabel.test:value")
actual := pathFromMetric(metric, "prefix.")
if expected != actual {
t.Errorf("Expected %s, got %s", expected, actual)