mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #528 from grafana/check-not-found-err-in-label-values-from-series

Browse source 
Check storage.ErrNotFound in labelValuesFromSeries
This commit is contained in:
George Krajcsovits 2023-09-07 10:07:13 +02:00 committed by GitHub
parent 002ae0aa1d 88ad42fb38
commit 7c067467a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tsdb/querier.go
View file

@ -434,6 +434,10 @@ func labelValuesFromSeries(r IndexReader, labelName string, refs []storage.Serie
var builder labels.ScratchBuilder var builder labels.ScratchBuilder
for _, ref := range refs { for _, ref := range refs {
err := r.Series(ref, &builder, nil) err := r.Series(ref, &builder, nil)
// Postings may be stale. Skip if no underlying series exists.
if errors.Cause(err) == storage.ErrNotFound {
continue
}
if err != nil { if err != nil {
return nil, errors.Wrapf(err, "label values for label %s", labelName) return nil, errors.Wrapf(err, "label values for label %s", labelName)
} }