mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

add queue_time slice to query_duration_seconds (#4050)

Browse source
This commit is contained in:
Tony Lee 2018-04-05 14:56:59 -04:00 committed by Brian Brazil
parent fe10b36b30
commit 7cd56f56df
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
promql/engine.go
View file

@ -50,6 +50,7 @@ const (
type engineMetrics struct { type engineMetrics struct {
currentQueries prometheus.Gauge currentQueries prometheus.Gauge
maxConcurrentQueries prometheus.Gauge maxConcurrentQueries prometheus.Gauge
queryQueueTime prometheus.Summary
queryPrepareTime prometheus.Summary queryPrepareTime prometheus.Summary
queryInnerEval prometheus.Summary queryInnerEval prometheus.Summary
queryResultAppend prometheus.Summary queryResultAppend prometheus.Summary
@ -177,6 +178,13 @@ func NewEngine(logger log.Logger, reg prometheus.Registerer, maxConcurrent int,
Name: "queries_concurrent_max", Name: "queries_concurrent_max",
Help: "The max number of concurrent queries.", Help: "The max number of concurrent queries.",
}), }),
queryQueueTime: prometheus.NewSummary(prometheus.SummaryOpts{
Namespace: namespace,
Subsystem: subsystem,
Name: "query_duration_seconds",
Help: "Query timings",
ConstLabels: prometheus.Labels{"slice": "queue_time"},
}),
queryPrepareTime: prometheus.NewSummary(prometheus.SummaryOpts{ queryPrepareTime: prometheus.NewSummary(prometheus.SummaryOpts{
Namespace: namespace, Namespace: namespace,
Subsystem: subsystem, Subsystem: subsystem,
@ -308,6 +316,7 @@ func (ng *Engine) exec(ctx context.Context, q *query) (Value, error) {
defer ng.gate.Done() defer ng.gate.Done()
queueTimer.Stop() queueTimer.Stop()
ng.metrics.queryQueueTime.Observe(queueTimer.ElapsedTime().Seconds())
// Cancel when execution is done or an error was raised. // Cancel when execution is done or an error was raised.
defer q.cancel() defer q.cancel()