From 81f2076dde6afddcec3c4b3f8b83836acafa9feb Mon Sep 17 00:00:00 2001 From: Callum Styan Date: Mon, 13 Nov 2023 16:12:19 -0800 Subject: [PATCH] fix label ranging Signed-off-by: Callum Styan --- storage/remote/codec.go | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/storage/remote/codec.go b/storage/remote/codec.go index f8df178fe6..6e1a4a3bf9 100644 --- a/storage/remote/codec.go +++ b/storage/remote/codec.go @@ -1034,12 +1034,12 @@ func min64WriteRequestToWriteRequest(redReq *prompb.MinimizedWriteRequestFixed64 for i, rts := range redReq.Timeseries { - lbls := Uint64RefToLabels(redReq.Symbols, rts.LabelSymbols) - ls := make([]prompb.Label, len(lbls)) - for j, l := range lbls { - ls[j].Name = l.Name - ls[j].Value = l.Value - } + Uint64RefToLabels(redReq.Symbols, rts.LabelSymbols).Range(func(l labels.Label) { + req.Timeseries[i].Labels = append(req.Timeseries[i].Labels, prompb.Label{ + Name: l.Name, + Value: l.Value, + }) + }) exemplars := make([]prompb.Exemplar, len(rts.Exemplars)) // TODO handle exemplars @@ -1054,7 +1054,6 @@ func min64WriteRequestToWriteRequest(redReq *prompb.MinimizedWriteRequestFixed64 // } //} - req.Timeseries[i].Labels = ls req.Timeseries[i].Samples = rts.Samples req.Timeseries[i].Exemplars = exemplars req.Timeseries[i].Histograms = rts.Histograms