mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-26 22:19:40 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Address krasi's comments

Browse source 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This commit is contained in:
Simon Pasquier 2018-09-12 16:02:15 +02:00
parent 1cee5b5b06
commit 8289501420
1 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
discovery/manager_test.go
View file

@ -899,18 +899,7 @@ func TestCoordinationWithReceiver(t *testing.T) {
expected []expect expected []expect
}{ }{
{ {
title: "Receiver should get an empty map even when the provider sends nothing and closes the channel", title: "Receiver should get all updates even when one provider closes its channel",
providers: map[string]Discoverer{
"empty": &onceProvider{},
},
expected: []expect{
{
tgs: map[string][]*targetgroup.Group{},
},
},
},
{
title: "Receiver should get updates even when one provider closes its channel",
providers: map[string]Discoverer{ providers: map[string]Discoverer{
"once1": &onceProvider{ "once1": &onceProvider{
tgs: []*targetgroup.Group{ tgs: []*targetgroup.Group{
@ -962,7 +951,7 @@ func TestCoordinationWithReceiver(t *testing.T) {
}, },
}, },
{ {
title: "Receiver should get updates even when the channel is blocked", title: "Receiver should get all updates even when the channel is blocked",
providers: map[string]Discoverer{ providers: map[string]Discoverer{
"mock1": newMockDiscoveryProvider( "mock1": newMockDiscoveryProvider(
update{ update{