mirror of
https://github.com/prometheus/prometheus.git
synced 2024-11-09 23:24:05 -08:00
HTTP SD: Validate HTTP config
Fixes #12762 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
This commit is contained in:
parent
b6f903b5f9
commit
8498b96a2b
|
@ -1857,6 +1857,10 @@ var expectedErrors = []struct {
|
|||
filename: "http_url_no_host.bad.yml",
|
||||
errMsg: "host is missing in URL",
|
||||
},
|
||||
{
|
||||
filename: "http_token_file.bad.yml",
|
||||
errMsg: "at most one of bearer_token & bearer_token_file must be configured",
|
||||
},
|
||||
{
|
||||
filename: "http_url_bad_scheme.bad.yml",
|
||||
errMsg: "URL scheme must be 'http' or 'https'",
|
||||
|
|
6
config/testdata/http_token_file.bad.yml
vendored
Normal file
6
config/testdata/http_token_file.bad.yml
vendored
Normal file
|
@ -0,0 +1,6 @@
|
|||
scrape_configs:
|
||||
- job_name: foo
|
||||
http_sd_configs:
|
||||
- url: http://foo
|
||||
bearer_token: foo
|
||||
bearer_token_file: foo
|
|
@ -99,7 +99,7 @@ func (c *SDConfig) UnmarshalYAML(unmarshal func(interface{}) error) error {
|
|||
if parsedURL.Host == "" {
|
||||
return fmt.Errorf("host is missing in URL")
|
||||
}
|
||||
return nil
|
||||
return c.HTTPClientConfig.Validate()
|
||||
}
|
||||
|
||||
const httpSDURLLabel = model.MetaLabelPrefix + "url"
|
||||
|
|
Loading…
Reference in a new issue