mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Add guard against non-monotonic samples in series

Browse source 
This can only happen due to data corruption.
This commit is contained in:
beorn7 2016-10-25 14:59:33 +02:00
parent 233a25a060
commit 876e5da4f8
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
storage/local/series.go
View file

@ -14,6 +14,7 @@
package local package local
import ( import (
"fmt"
"sort" "sort"
"sync" "sync"
"time" "time"
@ -496,6 +497,10 @@ func (s *memorySeries) preloadChunksForRange(
if throughIdx == len(s.chunkDescs) { if throughIdx == len(s.chunkDescs) {
throughIdx-- throughIdx--
} }
if fromIdx > throughIdx {
// Guard against nonsensical result. The caller will quarantine the series with a meaningful log entry.
return nopIter, fmt.Errorf("fromIdx=%d is greater than throughIdx=%d, likely caused by data corruption", fromIdx, throughIdx)
}
pinIndexes := make([]int, 0, throughIdx-fromIdx+1) pinIndexes := make([]int, 0, throughIdx-fromIdx+1)
for i := fromIdx; i <= throughIdx; i++ { for i := fromIdx; i <= throughIdx; i++ {