mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-01-13 14:57:40 -08:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Small cleanups and comments in tiered storage.

Browse source
This commit is contained in:
Julius Volz 2013-03-12 10:26:53 -07:00 committed by Matt T. Proud
parent f238b23b04
commit 894ecfe161
1 changed files with 23 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
storage/metric/tiered.go
View file

@ -383,6 +383,7 @@ func (t *tieredStorage) renderView(viewJob viewJob) (err error) {
for _, operation := range scanJob.operations { for _, operation := range scanJob.operations {
if seriesFrontier.lastTime.Before(operation.StartsAt()) { if seriesFrontier.lastTime.Before(operation.StartsAt()) {
// fmt.Printf("operation %s occurs after %s; aborting...\n", operation, seriesFrontier.lastTime) // fmt.Printf("operation %s occurs after %s; aborting...\n", operation, seriesFrontier.lastTime)
// XXXXXX
break break
} }
@ -390,9 +391,13 @@ func (t *tieredStorage) renderView(viewJob viewJob) (err error) {
if operation.StartsAt().Before(seriesFrontier.firstSupertime) { if operation.StartsAt().Before(seriesFrontier.firstSupertime) {
// fmt.Printf("operation %s occurs before %s; discarding...\n", operation, seriesFrontier.firstSupertime) // fmt.Printf("operation %s occurs before %s; discarding...\n", operation, seriesFrontier.firstSupertime)
// XXXXXX
continue continue
} }
// If the operation starts in the last supertime block, but before
// the end of a series, set the seek time to be within the key space
// so as not to invalidate the iterator.
if seriesFrontier.lastSupertime.Before(operation.StartsAt()) && !seriesFrontier.lastTime.Before(operation.StartsAt()) { if seriesFrontier.lastSupertime.Before(operation.StartsAt()) && !seriesFrontier.lastTime.Before(operation.StartsAt()) {
targetKey.Timestamp = indexable.EncodeTime(seriesFrontier.lastSupertime) targetKey.Timestamp = indexable.EncodeTime(seriesFrontier.lastSupertime)
} else { } else {
@ -403,7 +408,6 @@ func (t *tieredStorage) renderView(viewJob viewJob) (err error) {
rawKey, _ := coding.NewProtocolBufferEncoder(targetKey).Encode() rawKey, _ := coding.NewProtocolBufferEncoder(targetKey).Encode()
// XXX: Use frontiers to manage out of range queries.
iterator.Seek(rawKey) iterator.Seek(rawKey)
foundKey, err = extractSampleKey(iterator) foundKey, err = extractSampleKey(iterator)
@ -412,21 +416,27 @@ func (t *tieredStorage) renderView(viewJob viewJob) (err error) {
} }
var ( var (
fst = indexable.DecodeTime(foundKey.Timestamp) firstTime = indexable.DecodeTime(foundKey.Timestamp)
lst = time.Unix(*foundKey.LastTimestamp, 0) lastTime = time.Unix(*foundKey.LastTimestamp, 0)
) )
if !((operation.StartsAt().Before(fst)) || lst.Before(operation.StartsAt())) { if operation.StartsAt().Before(firstTime) {
// fmt.Printf("operation %s occurs inside of %s...\n", operation, foundKey) // Imagine the following supertime blocks with last time ranges:
foundValue, err = extractSampleValue(iterator) //
if err != nil { // Block 1: ft 1000 - lt 1009 <data>
panic(err) // Block 1: ft 1010 - lt 1019 <data>
} //
} else if operation.StartsAt().Before(fst) { // If an operation started at time 1005, we would first seek to the
fmt.Printf("operation %s may occur in next entity; fast forwarding...\n", operation) // block with supertime 1010, then need to rewind by one block by
// virtue of LevelDB iterator seek behavior.
fmt.Printf("operation %s may occur in next entity; rewinding...\n", operation)
iterator.Previous()
panic("oops") panic("oops")
} else { }
panic("illegal state") // fmt.Printf("operation %s occurs inside of %s...\n", operation, foundKey)
foundValue, err = extractSampleValue(iterator)
if err != nil {
panic(err)
} }
var ( var (