From 894f657c48d8229b026600a30d66edd5a9e14318 Mon Sep 17 00:00:00 2001 From: Jeanette Tan Date: Fri, 14 Apr 2023 18:22:51 +0800 Subject: [PATCH] Fix bugs from merge --- promql/engine_test.go | 4 ++-- web/api/v1/json_codec_test.go | 24 +++++++++--------------- 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/promql/engine_test.go b/promql/engine_test.go index 12cc2df54d..c2c8c3e884 100644 --- a/promql/engine_test.go +++ b/promql/engine_test.go @@ -3114,11 +3114,11 @@ func TestRangeQuery(t *testing.T) { Query: `foo > 2 or bar`, Result: Matrix{ Series{ - Points: []Point{{V: 1, T: 0}, {V: 3, T: 60000}, {V: 5, T: 120000}}, + Floats: []FPoint{{F: 1, T: 0}, {F: 3, T: 60000}, {F: 5, T: 120000}}, Metric: labels.FromStrings("__name__", "bar", "job", "2"), }, Series{ - Points: []Point{{V: 3, T: 60000}, {V: 5, T: 120000}}, + Floats: []FPoint{{F: 3, T: 60000}, {F: 5, T: 120000}}, Metric: labels.FromStrings("__name__", "foo", "job", "1"), }, }, diff --git a/web/api/v1/json_codec_test.go b/web/api/v1/json_codec_test.go index 642fb73c08..6b97b55e57 100644 --- a/web/api/v1/json_codec_test.go +++ b/web/api/v1/json_codec_test.go @@ -30,7 +30,7 @@ func TestJsonCodec_Encode(t *testing.T) { expected string }{ { - response: &queryData{ + response: &QueryData{ ResultType: parser.ValueTypeMatrix, Result: promql.Matrix{ promql.Series{ @@ -42,7 +42,7 @@ func TestJsonCodec_Encode(t *testing.T) { expected: `{"status":"success","data":{"resultType":"matrix","result":[{"metric":{"__name__":"foo"},"values":[[1,"1"]]}]}}`, }, { - response: &queryData{ + response: &QueryData{ ResultType: parser.ValueTypeMatrix, Result: promql.Matrix{ promql.Series{ @@ -160,21 +160,15 @@ func TestJsonCodec_Encode(t *testing.T) { }, } - for _, c := range cases { - s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - api := API{} - api.respond(w, c.response, nil) - })) - defer s.Close() + codec := JSONCodec{} - resp, err := http.Get(s.URL) + for _, c := range cases { + body, err := codec.Encode(&Response{ + Status: statusSuccess, + Data: c.response, + }) if err != nil { - t.Fatalf("Error on test request: %s", err) - } - body, err := io.ReadAll(resp.Body) - defer resp.Body.Close() - if err != nil { - t.Fatalf("Error reading response body: %s", err) + t.Fatalf("Error encoding response body: %s", err) } if string(body) != c.expected {