mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Reduce lock-protected area during scrape.

Browse source 
Change-Id: Iaa7faa7c916b1890b568d05bd8bfff6299b6767d
This commit is contained in:
Bjoern Rabenstein 2014-12-05 19:40:41 +01:00
parent fee88a7a77
commit 89bb376bce
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
retrieval/target.go
View file

@ -297,15 +297,14 @@ func (t *target) scrape(ingester extraction.Ingester) (err error) {
t.Lock() // Writing t.state and t.lastError requires the lock. t.Lock() // Writing t.state and t.lastError requires the lock.
if err == nil { if err == nil {
t.state = ALIVE t.state = ALIVE
t.recordScrapeHealth(ingester, timestamp, true)
labels[outcome] = failure labels[outcome] = failure
} else { } else {
t.state = UNREACHABLE t.state = UNREACHABLE
t.recordScrapeHealth(ingester, timestamp, false)
} }
targetOperationLatencies.With(labels).Observe(ms)
t.lastError = err t.lastError = err
t.Unlock() t.Unlock()
targetOperationLatencies.With(labels).Observe(ms)
t.recordScrapeHealth(ingester, timestamp, err == nil)
}(time.Now()) }(time.Now())
req, err := http.NewRequest("GET", t.Address(), nil) req, err := http.NewRequest("GET", t.Address(), nil)