mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-25 05:34:05 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Re-use timer instead of creating new ones on every sample

Browse source 
The docs for `time.After()` note that "The underlying Timer is not
recovered by the garbage collector until the timer fires".
This commit is contained in:
Bryan Boreham 2018-01-24 12:36:29 +00:00
parent f64014f70b
commit 8a4535e6ad
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
storage/remote/queue_manager.go
View file

@ -430,6 +430,8 @@ func (s *shards) runShard(i int) {
// anyways.
pendingSamples := model.Samples{}
timer := time.NewTimer(s.qm.cfg.BatchSendDeadline)
for {
select {
case sample, ok := <-queue:
@ -449,7 +451,11 @@ func (s *shards) runShard(i int) {
s.sendSamples(pendingSamples[:s.qm.cfg.MaxSamplesPerSend])
pendingSamples = pendingSamples[s.qm.cfg.MaxSamplesPerSend:]
}
case <-time.After(s.qm.cfg.BatchSendDeadline):
if !timer.Stop() {
<-timer.C
}
timer.Reset(s.qm.cfg.BatchSendDeadline)
case <-timer.C:
if len(pendingSamples) > 0 {
s.sendSamples(pendingSamples)
pendingSamples = pendingSamples[:0]