mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2024-12-24 21:24:05 -08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Fix race condition in Rule manager.Update() function

Browse source 
Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>
This commit is contained in:
fuling 2020-03-01 17:48:45 +08:00 committed by Julien Pivotto
parent 3fff701b77
commit 8b11d2cfb6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
rules/manager.go
View file

@ -921,7 +921,7 @@ func (m *Manager) Update(interval time.Duration, files []string, externalLabels
} }
wg.Add(1) wg.Add(1)
go func(newg *Group) { go func(newg *Group, oldg *Group) {
if ok { if ok {
oldg.stop() oldg.stop()
newg.CopyState(oldg) newg.CopyState(oldg)
@ -934,7 +934,7 @@ func (m *Manager) Update(interval time.Duration, files []string, externalLabels
newg.run(m.opts.Context) newg.run(m.opts.Context)
}() }()
wg.Done() wg.Done()
}(newg) }(newg, oldg)
} }
// Stop remaining old groups. // Stop remaining old groups.