From d19e749dc6a76053c7f07709221344782818ea75 Mon Sep 17 00:00:00 2001
From: Julius Volz <julius.volz@gmail.com>
Date: Tue, 5 Nov 2024 16:12:05 +0100
Subject: [PATCH] Fix selector / series formatting for empty metric names

Fixes https://github.com/prometheus/prometheus/issues/15335

Signed-off-by: Julius Volz <julius.volz@gmail.com>
---
 .../src/promql/serializeAndFormat.test.ts          | 14 ++++++++++++++
 web/ui/mantine-ui/src/promql/utils.ts              |  2 +-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/web/ui/mantine-ui/src/promql/serializeAndFormat.test.ts b/web/ui/mantine-ui/src/promql/serializeAndFormat.test.ts
index a2b97ec904..da4be7ced1 100644
--- a/web/ui/mantine-ui/src/promql/serializeAndFormat.test.ts
+++ b/web/ui/mantine-ui/src/promql/serializeAndFormat.test.ts
@@ -157,6 +157,20 @@ describe("serializeNode and formatNode", () => {
         },
         output: "metric_name[5m] @ start() offset -10m",
       },
+      {
+        node: {
+          type: nodeType.vectorSelector,
+          name: "", // Test formatting a selector with an empty metric name.
+          matchers: [
+            { type: matchType.equal, name: "label1", value: "value1" },
+          ],
+          offset: 0,
+          timestamp: null,
+          startOrEnd: null,
+        },
+        output:
+          '{label1="value1"}',
+      },
 
       // Aggregations.
       {
diff --git a/web/ui/mantine-ui/src/promql/utils.ts b/web/ui/mantine-ui/src/promql/utils.ts
index 2f1cc11d2f..2addeed8ab 100644
--- a/web/ui/mantine-ui/src/promql/utils.ts
+++ b/web/ui/mantine-ui/src/promql/utils.ts
@@ -271,7 +271,7 @@ const metricNameRe = /^[a-zA-Z_:][a-zA-Z0-9_:]*$/;
 const labelNameCharsetRe = /^[a-zA-Z_][a-zA-Z0-9_]*$/;
 
 export const metricContainsExtendedCharset = (str: string) => {
-  return !metricNameRe.test(str);
+  return str !== "" && !metricNameRe.test(str);
 };
 
 export const labelNameContainsExtendedCharset = (str: string) => {