mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

discovery/ec2: pass context to the client (#5234)

Browse source 
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This commit is contained in:
Simon Pasquier 2019-02-26 14:48:03 +01:00 committed by GitHub
parent 4997dcb4a1
commit 8f578d9c6b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
discovery/ec2/ec2.go
View file

@ -167,7 +167,7 @@ func (d *Discovery) Run(ctx context.Context, ch chan<- []*targetgroup.Group) {
defer ticker.Stop() defer ticker.Stop()
// Get an initial set right away. // Get an initial set right away.
tg, err := d.refresh() tg, err := d.refresh(ctx)
if err != nil { if err != nil {
level.Error(d.logger).Log("msg", "Refresh failed", "err", err) level.Error(d.logger).Log("msg", "Refresh failed", "err", err)
} else { } else {
@ -181,7 +181,7 @@ func (d *Discovery) Run(ctx context.Context, ch chan<- []*targetgroup.Group) {
for { for {
select { select {
case <-ticker.C: case <-ticker.C:
tg, err := d.refresh() tg, err := d.refresh(ctx)
if err != nil { if err != nil {
level.Error(d.logger).Log("msg", "Refresh failed", "err", err) level.Error(d.logger).Log("msg", "Refresh failed", "err", err)
continue continue
@ -198,7 +198,7 @@ func (d *Discovery) Run(ctx context.Context, ch chan<- []*targetgroup.Group) {
} }
} }
func (d *Discovery) refresh() (tg *targetgroup.Group, err error) { func (d *Discovery) refresh(ctx context.Context) (tg *targetgroup.Group, err error) {
t0 := time.Now() t0 := time.Now()
defer func() { defer func() {
ec2SDRefreshDuration.Observe(time.Since(t0).Seconds()) ec2SDRefreshDuration.Observe(time.Since(t0).Seconds())
@ -236,7 +236,7 @@ func (d *Discovery) refresh() (tg *targetgroup.Group, err error) {
input := &ec2.DescribeInstancesInput{Filters: filters} input := &ec2.DescribeInstancesInput{Filters: filters}
if err = ec2s.DescribeInstancesPages(input, func(p *ec2.DescribeInstancesOutput, lastPage bool) bool { if err = ec2s.DescribeInstancesPagesWithContext(ctx, input, func(p *ec2.DescribeInstancesOutput, lastPage bool) bool {
for _, r := range p.Reservations { for _, r := range p.Reservations {
for _, inst := range r.Instances { for _, inst := range r.Instances {
if inst.PrivateIpAddress == nil { if inst.PrivateIpAddress == nil {