mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Use sampleBuf instead of maintaining lastValue. (#444)

Browse source 
This cuts the size of memSize by 8B.

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
This commit is contained in:
Brian Brazil 2018-11-14 14:02:32 +00:00 committed by GitHub
parent 10632217ce
commit 910f3021b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
head.go
View file

@ -1364,7 +1364,6 @@ type memSeries struct {
firstChunkID int firstChunkID int
nextAt int64 // Timestamp at which to cut the next chunk. nextAt int64 // Timestamp at which to cut the next chunk.
lastValue float64
sampleBuf [4]sample sampleBuf [4]sample
pendingCommit bool // Whether there are samples waiting to be committed to this series. pendingCommit bool // Whether there are samples waiting to be committed to this series.
@ -1432,7 +1431,7 @@ func (s *memSeries) appendable(t int64, v float64) error {
} }
// We are allowing exact duplicates as we can encounter them in valid cases // We are allowing exact duplicates as we can encounter them in valid cases
// like federation and erroring out at that time would be extremely noisy. // like federation and erroring out at that time would be extremely noisy.
if math.Float64bits(s.lastValue) != math.Float64bits(v) { if math.Float64bits(s.sampleBuf[3].v) != math.Float64bits(v) {
return ErrAmendSample return ErrAmendSample
} }
return nil return nil
@ -1504,8 +1503,6 @@ func (s *memSeries) append(t int64, v float64) (success, chunkCreated bool) {
c.maxTime = t c.maxTime = t
s.lastValue = v
s.sampleBuf[0] = s.sampleBuf[1] s.sampleBuf[0] = s.sampleBuf[1]
s.sampleBuf[1] = s.sampleBuf[2] s.sampleBuf[1] = s.sampleBuf[2]
s.sampleBuf[2] = s.sampleBuf[3] s.sampleBuf[2] = s.sampleBuf[3]