mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

added name label to all discovery metrics (#5002)

Browse source 
Signed-off-by: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
This commit is contained in:
Ilya Gladyshev 2018-12-20 17:47:29 +03:00 committed by Brian Brazil
parent b94eea482c
commit 922c17e119
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
discovery/manager.go
View file

@ -41,11 +41,12 @@ import (
) )
var ( var (
failedConfigs = prometheus.NewCounter( failedConfigs = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "prometheus_sd_configs_failed_total", Name: "prometheus_sd_configs_failed_total",
Help: "Total number of service discovery configurations that failed to load.", Help: "Total number of service discovery configurations that failed to load.",
}, },
[]string{"name"},
) )
discoveredTargets = prometheus.NewGaugeVec( discoveredTargets = prometheus.NewGaugeVec(
prometheus.GaugeOpts{ prometheus.GaugeOpts{
@ -54,23 +55,26 @@ var (
}, },
[]string{"name", "config"}, []string{"name", "config"},
) )
receivedUpdates = prometheus.NewCounter( receivedUpdates = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "prometheus_sd_received_updates_total", Name: "prometheus_sd_received_updates_total",
Help: "Total number of update events received from the SD providers.", Help: "Total number of update events received from the SD providers.",
}, },
[]string{"name"},
) )
delayedUpdates = prometheus.NewCounter( delayedUpdates = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "prometheus_sd_updates_delayed_total", Name: "prometheus_sd_updates_delayed_total",
Help: "Total number of update events that couldn't be sent immediately.", Help: "Total number of update events that couldn't be sent immediately.",
}, },
[]string{"name"},
) )
sentUpdates = prometheus.NewCounter( sentUpdates = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "prometheus_sd_updates_total", Name: "prometheus_sd_updates_total",
Help: "Total number of update events sent to the SD consumers.", Help: "Total number of update events sent to the SD consumers.",
}, },
[]string{"name"},
) )
) )
@ -226,7 +230,7 @@ func (m *Manager) updater(ctx context.Context, p *provider, updates chan []*targ
case <-ctx.Done(): case <-ctx.Done():
return return
case tgs, ok := <-updates: case tgs, ok := <-updates:
receivedUpdates.Inc() receivedUpdates.WithLabelValues(m.name).Inc()
if !ok { if !ok {
level.Debug(m.logger).Log("msg", "discoverer channel closed", "provider", p.name) level.Debug(m.logger).Log("msg", "discoverer channel closed", "provider", p.name)
return return
@ -255,11 +259,11 @@ func (m *Manager) sender() {
case <-ticker.C: // Some discoverers send updates too often so we throttle these with the ticker. case <-ticker.C: // Some discoverers send updates too often so we throttle these with the ticker.
select { select {
case <-m.triggerSend: case <-m.triggerSend:
sentUpdates.Inc() sentUpdates.WithLabelValues(m.name).Inc()
select { select {
case m.syncCh <- m.allGroups(): case m.syncCh <- m.allGroups():
default: default:
delayedUpdates.Inc() delayedUpdates.WithLabelValues(m.name).Inc()
level.Debug(m.logger).Log("msg", "discovery receiver's channel was full so will retry the next cycle") level.Debug(m.logger).Log("msg", "discovery receiver's channel was full so will retry the next cycle")
select { select {
case m.triggerSend <- struct{}{}: case m.triggerSend <- struct{}{}:
@ -328,7 +332,7 @@ func (m *Manager) registerProviders(cfg sd_config.ServiceDiscoveryConfig, setNam
d, err := newDiscoverer() d, err := newDiscoverer()
if err != nil { if err != nil {
level.Error(m.logger).Log("msg", "Cannot create service discovery", "err", err, "type", t) level.Error(m.logger).Log("msg", "Cannot create service discovery", "err", err, "type", t)
failedConfigs.Inc() failedConfigs.WithLabelValues(m.name).Inc()
return return
} }