From 9258e40589d971c0a009dccaa13462b87fb9454a Mon Sep 17 00:00:00 2001 From: Mikel Olasagasti Uranga Date: Sat, 18 Jan 2025 13:21:51 +0100 Subject: [PATCH] parser: fix non-constant format string call (#15835) Go 1.24 enhanced vet's printf analyzer to report calls of the form fmt.Printf(s), where s is a non-constant format string, with no other arguments. This change makes parser tests to fail. Signed-off-by: Mikel Olasagasti Uranga --- promql/parser/generated_parser.y | 2 +- promql/parser/generated_parser.y.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/promql/parser/generated_parser.y b/promql/parser/generated_parser.y index ca710b1ab0..cdb4532d3b 100644 --- a/promql/parser/generated_parser.y +++ b/promql/parser/generated_parser.y @@ -488,7 +488,7 @@ matrix_selector : expr LEFT_BRACKET number_duration_literal RIGHT_BRACKET if errMsg != ""{ errRange := mergeRanges(&$2, &$4) - yylex.(*parser).addParseErrf(errRange, errMsg) + yylex.(*parser).addParseErrf(errRange, "%s", errMsg) } numLit, _ := $3.(*NumberLiteral) diff --git a/promql/parser/generated_parser.y.go b/promql/parser/generated_parser.y.go index 04bc081f2f..78d5e15245 100644 --- a/promql/parser/generated_parser.y.go +++ b/promql/parser/generated_parser.y.go @@ -1385,7 +1385,7 @@ yydefault: if errMsg != "" { errRange := mergeRanges(&yyDollar[2].item, &yyDollar[4].item) - yylex.(*parser).addParseErrf(errRange, errMsg) + yylex.(*parser).addParseErrf(errRange, "%s", errMsg) } numLit, _ := yyDollar[3].node.(*NumberLiteral)