mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Remove a TODO that is no longer valid (#11186)

Browse source 
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
This commit is contained in:
Ganesh Vernekar 2022-08-18 22:47:12 +05:30 committed by GitHub
parent c9fd3c235d
commit 9325caa41c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
promql/engine_test.go
View file

@ -3422,21 +3422,11 @@ func TestSparseHistogram_HistogramQuantile(t *testing.T) {
}, },
} }
test, err := NewTest(t, "")
require.NoError(t, err)
t.Cleanup(test.Close)
for i, c := range cases { for i, c := range cases {
t.Run(c.text, func(t *testing.T) { t.Run(c.text, func(t *testing.T) {
// TODO(codesome): Check if TSDB is handling these histograms properly.
// When testing, the 3rd case of both positive and
// negative buckets did not get any histograms in the
// query engine when the storage was shared, even with a
// good time gap between all histograms. It is possible
// that the recode is failing. It was fine between the
// first two cases where there is a change of bucket
// layout.
test, err := NewTest(t, "")
require.NoError(t, err)
t.Cleanup(test.Close)
seriesName := "sparse_histogram_series" seriesName := "sparse_histogram_series"
lbls := labels.FromStrings("__name__", seriesName) lbls := labels.FromStrings("__name__", seriesName)
engine := test.QueryEngine() engine := test.QueryEngine()
@ -3461,7 +3451,7 @@ func TestSparseHistogram_HistogramQuantile(t *testing.T) {
require.Len(t, vector, 1) require.Len(t, vector, 1)
require.Nil(t, vector[0].H) require.Nil(t, vector[0].H)
require.Equal(t, sc.value, vector[0].V) require.True(t, almostEqual(sc.value, vector[0].V))
}) })
} }
}) })