exit early and panic for non slice on buffer.Put

pkg/pool/pool.go

@@ -71,16 +71,16 @@ func (p *Pool) Get(sz int) interface{} {
 }
 
 // Put adds a slice to the right bucket in the pool.
-func (p *Pool) Put(s interface{}) error {
+func (p *Pool) Put(s interface{}) {
 	slice := reflect.ValueOf(s)
-	if slice.Kind() == reflect.Slice {
+
-		for i, size := range p.sizes {
+	if slice.Kind() != reflect.Slice {
-			if slice.Cap() > size {
+		panic(fmt.Sprintf("%+v is not a slice", slice))
-				continue
+	}
-			}
+	for i, size := range p.sizes {
-			p.buckets[i].Put(slice.Slice(0, 0).Interface())
+		if slice.Cap() > size {
-			return nil
+			continue
-		}
+		}
+		p.buckets[i].Put(slice.Slice(0, 0).Interface())
 	}
-	return fmt.Errorf("%+v is not a slice", slice)
 }

scrape/scrape.go

@@ -699,9 +699,7 @@ mainLoop:
 			}
 		}
 
-		if err := sl.buffers.Put(b); err != nil {
+		sl.buffers.Put(b)
-			level.Error(sl.l).Log("msg", "buffer pool error", "err", err)
-		}
 
 		if scrapeErr == nil {
 			scrapeErr = appErr