mudhorn/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-03-05 20:59:13 -08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

rules tests: use EmptyLabels instead of nil

Browse source 
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This commit is contained in:
Bryan Boreham 2022-10-27 18:32:54 +01:00
parent aa9385ea88
commit 9bb9faabb1
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
rules/manager_test.go
View file

@ -831,7 +831,7 @@ func TestUpdate_AlwaysRestore(t *testing.T) {
ruleManager.start() ruleManager.start()
defer ruleManager.Stop() defer ruleManager.Stop()
err := ruleManager.Update(10*time.Second, []string{"fixtures/rules_alerts.yaml"}, nil, "", nil) err := ruleManager.Update(10*time.Second, []string{"fixtures/rules_alerts.yaml"}, labels.EmptyLabels(), "", nil)
require.NoError(t, err) require.NoError(t, err)
for _, g := range ruleManager.groups { for _, g := range ruleManager.groups {
@ -840,7 +840,7 @@ func TestUpdate_AlwaysRestore(t *testing.T) {
} }
// Use different file, so groups haven't changed, therefore, we expect state restoration // Use different file, so groups haven't changed, therefore, we expect state restoration
err = ruleManager.Update(10*time.Second, []string{"fixtures/rules_alerts2.yaml"}, nil, "", nil) err = ruleManager.Update(10*time.Second, []string{"fixtures/rules_alerts2.yaml"}, labels.EmptyLabels(), "", nil)
for _, g := range ruleManager.groups { for _, g := range ruleManager.groups {
require.True(t, g.shouldRestore) require.True(t, g.shouldRestore)
} }
@ -863,7 +863,7 @@ func TestUpdate_AlwaysRestoreDoesntAffectUnchangedGroups(t *testing.T) {
ruleManager.start() ruleManager.start()
defer ruleManager.Stop() defer ruleManager.Stop()
err := ruleManager.Update(10*time.Second, files, nil, "", nil) err := ruleManager.Update(10*time.Second, files, labels.EmptyLabels(), "", nil)
require.NoError(t, err) require.NoError(t, err)
for _, g := range ruleManager.groups { for _, g := range ruleManager.groups {
@ -872,7 +872,7 @@ func TestUpdate_AlwaysRestoreDoesntAffectUnchangedGroups(t *testing.T) {
} }
// Use the same file, so groups haven't changed, therefore, we don't expect state restoration // Use the same file, so groups haven't changed, therefore, we don't expect state restoration
err = ruleManager.Update(10*time.Second, files, nil, "", nil) err = ruleManager.Update(10*time.Second, files, labels.EmptyLabels(), "", nil)
for _, g := range ruleManager.groups { for _, g := range ruleManager.groups {
require.False(t, g.shouldRestore) require.False(t, g.shouldRestore)
} }
@ -1090,7 +1090,7 @@ func reloadRules(rgs *rulefmt.RuleGroups, t *testing.T, tmpFile *os.File, ruleMa
_, _ = tmpFile.Seek(0, 0) _, _ = tmpFile.Seek(0, 0)
_, err = tmpFile.Write(bs) _, err = tmpFile.Write(bs)
require.NoError(t, err) require.NoError(t, err)
err = ruleManager.Update(interval, []string{tmpFile.Name()}, nil, "", nil) err = ruleManager.Update(interval, []string{tmpFile.Name()}, labels.EmptyLabels(), "", nil)
require.NoError(t, err) require.NoError(t, err)
} }
@ -1686,7 +1686,7 @@ groups:
}, },
}) })
m.start() m.start()
err = m.Update(time.Second, []string{fname}, nil, "", nil) err = m.Update(time.Second, []string{fname}, labels.EmptyLabels(), "", nil)
require.NoError(t, err) require.NoError(t, err)
rgs := m.RuleGroups() rgs := m.RuleGroups()

2
rules/origin_test.go
View file

@ -29,7 +29,7 @@ import (
type unknownRule struct{} type unknownRule struct{}
func (u unknownRule) Name() string { return "" } func (u unknownRule) Name() string { return "" }
func (u unknownRule) Labels() labels.Labels { return nil } func (u unknownRule) Labels() labels.Labels { return labels.EmptyLabels() }
func (u unknownRule) Eval(ctx context.Context, evalDelay time.Duration, time time.Time, queryFunc QueryFunc, url *url.URL, i int) (promql.Vector, error) { func (u unknownRule) Eval(ctx context.Context, evalDelay time.Duration, time time.Time, queryFunc QueryFunc, url *url.URL, i int) (promql.Vector, error) {
return nil, nil return nil, nil
} }